Make GrFontScaler not be ref-counted

src/gpu/text/GrTextUtils.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrTextUtils.h"
 
 #include "GrAtlasTextBlob.h"
@@ skipping 554 matching lines @@
     if (kUnknown_SkPixelGeometry == surfaceProps.pixelGeometry() || ShouldDisableLCD(paint)) {
         flags &= ~SkPaint::kLCDRenderText_Flag;
         flags |= SkPaint::kGenA8FromLCD_Flag;
     }
 
     return flags;
 }
 
 static void glyph_cache_aux_proc(void* data) {
     GrFontScaler* scaler = (GrFontScaler*)data;
-    SkSafeUnref(scaler);
+    delete scaler;
 }
 
 GrFontScaler* GrTextUtils::GetGrFontScaler(SkGlyphCache* cache) {

[bungeman-skia, 2016/05/17 14:14:05]

It actually seems strange that this is in GrTextUtils as well, since this is the
only valid way to call the constructor for GrFontScaler (it's a factory). It
seems like this function should be named GrFontScaler::Get(SkGlyphCache* strike)
and the GrFontScaler constructor be made private.

     void* auxData;
     GrFontScaler* scaler = nullptr;
 
     if (cache->getAuxProcData(glyph_cache_aux_proc, &auxData)) {
         scaler = (GrFontScaler*)auxData;
     }
     if (nullptr == scaler) {
         scaler = new GrFontScaler(cache);
         cache->setAuxProc(glyph_cache_aux_proc, scaler);
     }
 
     return scaler;
 }