Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 1982263005: Adjust key sequence string (Closed)

Created:
4 years, 7 months ago by David Tseng
Modified:
4 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust key sequence string 'Cvox' as of TOT gets read as 'C V O X'. By replacing the above with 'ChromeVox', we make the string itself less ambiguous and more understandable. This string gets used in options and in the panel. BUG=612559 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/42aa519ebe3bf1326bf5bb2cee5056829875bba4 Cr-Commit-Position: refs/heads/master@{#394246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/common/key_util.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 7 months ago (2016-05-17 20:44:44 UTC) #4
dmazzoni
lgtm
4 years, 7 months ago (2016-05-17 20:59:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982263005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982263005/1
4 years, 7 months ago (2016-05-17 20:59:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 22:25:51 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 22:27:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42aa519ebe3bf1326bf5bb2cee5056829875bba4
Cr-Commit-Position: refs/heads/master@{#394246}

Powered by Google App Engine
This is Rietveld 408576698