Don't use LCD antialiasing if Fontconfig doesn't support hinting

Don't use LCD antialiasing if Fontconfig doesn't support hinting

Some Freetype implementations (like the one packaged with Fedora) do
not support hinting due to patents 6219025, 6239783, 6307566, 6225973,
6243070, 6393145, 6421054, 6282327, and 6624828; the latest one expires
10/7/19.  This makes LCD antialiasing very ugly, so we instead fall back
on NORMAL antialiasing.

A before/after on Fedora: https://bugs.chromium.org/p/chromium/issues/detail?id=479400#c31

BUG=479400
Committed: https://pdfium.googlesource.com/pdfium/+/992def065be348d6f8157fab75aee312f5f45558

[Tom (Use chromium acct), 2016-05-17 18:12:22]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 18:12:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1982263004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1982263004/1

[commit-bot: I haz the power, 2016-05-17 18:12:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 18:12:29]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-pdfium-committers".
Note that this has nothing to do with OWNERS files.

[Tom (Use chromium acct), 2016-05-17 18:18:57]

Description was changed from

==========
Don't use LCD antialiasing if Fontconfig doesn't support hinting

Some Freetype implementations (like the one packaged with Fedora) do
not support hinting due to patents 6219025, 6239783, 6307566, 6225973,
6243070, 6393145, 6421054, 6282327, and 6624828; the latest one expires
10/7/19.  This makes LCD antialiasing very ugly, so we instead fall back
on NORMAL antialiasing.

BUG=479400
==========

to

==========
Don't use LCD antialiasing if Fontconfig doesn't support hinting

Some Freetype implementations (like the one packaged with Fedora) do
not support hinting due to patents 6219025, 6239783, 6307566, 6225973,
6243070, 6393145, 6421054, 6282327, and 6624828; the latest one expires
10/7/19.  This makes LCD antialiasing very ugly, so we instead fall back
on NORMAL antialiasing.

A before/after on Fedora can be seen here
https://bugs.chromium.org/p/chromium/issues/detail?id=479400#c31

BUG=479400
==========

[Tom (Use chromium acct), 2016-05-17 18:19:20]

Description was changed from

==========
Don't use LCD antialiasing if Fontconfig doesn't support hinting

Some Freetype implementations (like the one packaged with Fedora) do
not support hinting due to patents 6219025, 6239783, 6307566, 6225973,
6243070, 6393145, 6421054, 6282327, and 6624828; the latest one expires
10/7/19.  This makes LCD antialiasing very ugly, so we instead fall back
on NORMAL antialiasing.

A before/after on Fedora can be seen here
https://bugs.chromium.org/p/chromium/issues/detail?id=479400#c31

BUG=479400
==========

to

==========
Don't use LCD antialiasing if Fontconfig doesn't support hinting

Some Freetype implementations (like the one packaged with Fedora) do
not support hinting due to patents 6219025, 6239783, 6307566, 6225973,
6243070, 6393145, 6421054, 6282327, and 6624828; the latest one expires
10/7/19.  This makes LCD antialiasing very ugly, so we instead fall back
on NORMAL antialiasing.

A before/after on Fedora:
https://bugs.chromium.org/p/chromium/issues/detail?id=479400#c31

BUG=479400
==========

[Tom (Use chromium acct), 2016-05-17 18:19:30]

thomasanderson@google.com changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-05-17 18:30:54]

https://codereview.chromium.org/1982263004/diff/1/core/fxge/ge/fx_ge_fontmap.cpp
File core/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/1982263004/diff/1/core/fxge/ge/fx_ge_fontmap....
core/fxge/ge/fx_ge_fontmap.cpp:457: CFX_FontMgr::CFX_FontMgr() :
m_FTLibrary(nullptr) {
Can you initialize |m_FTLibrarySupportsHinting| to false here anyway?

https://codereview.chromium.org/1982263004/diff/1/core/fxge/ge/fx_ge_fontmap....
core/fxge/ge/fx_ge_fontmap.cpp:655: if (!m_FTLibrary)
And don't worry about this.

[Lei Zhang, 2016-05-17 18:30:59]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 18:31:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1982263004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1982263004/1

[Lei Zhang, 2016-05-17 18:37:37]

Bots look happy so far, so lgtm.

[commit-bot: I haz the power, 2016-05-17 18:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 18:49:15]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-05-17 19:06:37]

https://codereview.chromium.org/1982263004/diff/1/core/fxge/ge/fx_ge_fontmap.cpp
File core/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/1982263004/diff/1/core/fxge/ge/fx_ge_fontmap....
core/fxge/ge/fx_ge_fontmap.cpp:457: CFX_FontMgr::CFX_FontMgr() :
m_FTLibrary(nullptr) {
On 2016/05/17 18:30:54, Lei Zhang wrote:
> Can you initialize |m_FTLibrarySupportsHinting| to false here anyway?

Done.

https://codereview.chromium.org/1982263004/diff/1/core/fxge/ge/fx_ge_fontmap....
core/fxge/ge/fx_ge_fontmap.cpp:655: if (!m_FTLibrary)
On 2016/05/17 18:30:54, Lei Zhang wrote:
> And don't worry about this.

Done.

[Tom (Use chromium acct), 2016-05-17 19:07:32]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 19:07:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1982263004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1982263004/20001

[commit-bot: I haz the power, 2016-05-17 19:27:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 19:27:27]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-05-17 19:29:44]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-05-17 19:29:45]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1982263004/#ps20001
(title: "Initialize m_FTLibrarySupportsHinting")

[commit-bot: I haz the power, 2016-05-17 19:29:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1982263004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1982263004/20001

[commit-bot: I haz the power, 2016-05-17 19:30:09]

Description was changed from

==========
Don't use LCD antialiasing if Fontconfig doesn't support hinting

Some Freetype implementations (like the one packaged with Fedora) do
not support hinting due to patents 6219025, 6239783, 6307566, 6225973,
6243070, 6393145, 6421054, 6282327, and 6624828; the latest one expires
10/7/19.  This makes LCD antialiasing very ugly, so we instead fall back
on NORMAL antialiasing.

A before/after on Fedora:
https://bugs.chromium.org/p/chromium/issues/detail?id=479400#c31

BUG=479400
==========

to

==========
Don't use LCD antialiasing if Fontconfig doesn't support hinting

Some Freetype implementations (like the one packaged with Fedora) do
not support hinting due to patents 6219025, 6239783, 6307566, 6225973,
6243070, 6393145, 6421054, 6282327, and 6624828; the latest one expires
10/7/19.  This makes LCD antialiasing very ugly, so we instead fall back
on NORMAL antialiasing.

A before/after on Fedora:
https://bugs.chromium.org/p/chromium/issues/detail?id=479400#c31

BUG=479400

Committed:
https://pdfium.googlesource.com/pdfium/+/992def065be348d6f8157fab75aee312f5f4...
==========

[commit-bot: I haz the power, 2016-05-17 19:30:10]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/992def065be348d6f8157fab75aee312f5f4...