Remove Windows XP specific socket cleanup timer from net/socket.

Remove Windows Vista/XP specific code from net/socket.

The socket code currently contains an option to cleanup idle socket after a small delay. This option is only used on Windows as a workaround for Windows XP. Now that Windows XP is no longer supported, this option can be removed.

BUG=580691
Committed: https://crrev.com/003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68
Cr-Commit-Position: refs/heads/master@{#394886}

[martijnc, 2016-05-17 17:58:20]

martijn@martijnc.be changed reviewers:
+ mmenke@chromium.org

[martijnc, 2016-05-17 19:09:31]

Description was changed from

==========
Remove Windows Vista/XP specific code from net/socket and net/url_request.

BUG=580691
==========

to

==========
Remove Windows Vista/XP specific code from net/socket.

BUG=580691
==========

[martijnc, 2016-05-17 19:37:12]

Patchset #1 (id:1) has been deleted

[martijnc, 2016-05-18 18:35:30]

martijn@martijnc.be changed reviewers:
- mmenke@chromium.org

[martijnc, 2016-05-18 20:12:47]

Description was changed from

==========
Remove Windows Vista/XP specific code from net/socket.

BUG=580691
==========

to

==========
Remove Windows Vista/XP specific code from net/socket.

The socket code currently contains an option to cleanup idle socket with a small
delay. This option is only used on Windows as a workaround for Windows XP. Now
that Windows XP is no longer supported, this option can be remove.

BUG=580691
==========

[martijnc, 2016-05-18 20:12:58]

Patchset #1 (id:20001) has been deleted

[martijnc, 2016-05-18 20:16:46]

Description was changed from

==========
Remove Windows Vista/XP specific code from net/socket.

The socket code currently contains an option to cleanup idle socket with a small
delay. This option is only used on Windows as a workaround for Windows XP. Now
that Windows XP is no longer supported, this option can be remove.

BUG=580691
==========

to

==========
Remove Windows Vista/XP specific code from net/socket.

The socket code currently contains an option to cleanup idle socket with a small
delay. This option is only used on Windows as a workaround for Windows XP. Now
that Windows XP is no longer supported, this option can be removed.

BUG=580691
==========

[martijnc, 2016-05-18 20:16:46]

martijn@martijnc.be changed reviewers:
+ mmenke@chromium.org

[martijnc, 2016-05-18 20:34:08]

Description was changed from

==========
Remove Windows Vista/XP specific code from net/socket.

The socket code currently contains an option to cleanup idle socket with a small
delay. This option is only used on Windows as a workaround for Windows XP. Now
that Windows XP is no longer supported, this option can be removed.

BUG=580691
==========

to

==========
Remove Windows Vista/XP specific code from net/socket.

The socket code currently contains an option to cleanup idle socket after a
small delay. This option is only used on Windows as a workaround for Windows XP.
Now that Windows XP is no longer supported, this option can be removed.

BUG=580691
==========

[martijnc, 2016-05-18 21:48:11]

Hi, can you review this patch? Thanks!

[mmenke, 2016-05-18 21:59:45]

https://codereview.chromium.org/1982263003/diff/40001/net/socket/client_socke...
File net/socket/client_socket_pool_base_unittest.cc (right):

https://codereview.chromium.org/1982263003/diff/40001/net/socket/client_socke...
net/socket/client_socket_pool_base_unittest.cc:2060:
TEST_F(ClientSocketPoolBaseTest, CleanupTimedOutIdleSockets) {
Think it makes more sense to remove this test, and keep the two above instead
(After renaming them).

[martijnc, 2016-05-19 16:54:15]

Patchset #2 (id:60001) has been deleted

[martijnc, 2016-05-19 19:51:41]

https://codereview.chromium.org/1982263003/diff/40001/net/socket/client_socke...
File net/socket/client_socket_pool_base_unittest.cc (right):

https://codereview.chromium.org/1982263003/diff/40001/net/socket/client_socke...
net/socket/client_socket_pool_base_unittest.cc:2060:
TEST_F(ClientSocketPoolBaseTest, CleanupTimedOutIdleSockets) {
On 2016/05/18 at 21:59:45, mmenke wrote:
> Think it makes more sense to remove this test, and keep the two above instead
(After renaming them).

Done.

[mmenke, 2016-05-19 20:12:21]

LGTM (That test failure is unrelated flake - seen that test fail on other random
CLs).  Thanks for doing this!

[martijnc, 2016-05-19 21:09:40]

The CQ bit was checked by martijn@martijnc.be

[martijnc, 2016-05-19 21:09:40]

Thank you.

[commit-bot: I haz the power, 2016-05-19 21:10:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1982263003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1982263003/80001

[commit-bot: I haz the power, 2016-05-19 22:24:53]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-05-19 22:26:07]

Description was changed from

==========
Remove Windows Vista/XP specific code from net/socket.

The socket code currently contains an option to cleanup idle socket after a
small delay. This option is only used on Windows as a workaround for Windows XP.
Now that Windows XP is no longer supported, this option can be removed.

BUG=580691
==========

to

==========
Remove Windows Vista/XP specific code from net/socket.

The socket code currently contains an option to cleanup idle socket after a
small delay. This option is only used on Windows as a workaround for Windows XP.
Now that Windows XP is no longer supported, this option can be removed.

BUG=580691

Committed: https://crrev.com/003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68
Cr-Commit-Position: refs/heads/master@{#394886}
==========

[commit-bot: I haz the power, 2016-05-19 22:26:08]

Patchset 2 (id:??) landed as
https://crrev.com/003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68
Cr-Commit-Position: refs/heads/master@{#394886}