Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: content/browser/indexed_db/indexed_db_unittest.cc

Issue 198223002: Added IndexedDBPendingConnection to group up a bunch of parameters that get (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge out Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_unittest.cc b/content/browser/indexed_db/indexed_db_unittest.cc
index c3704b83e4bb943b8da588c08791f7212e41a810..5bf1efb4615d5657e32e06e85f725a38375c5cc3 100644
--- a/content/browser/indexed_db/indexed_db_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_unittest.cc
@@ -174,18 +174,22 @@ TEST_F(IndexedDBTest, ForceCloseOpenDatabasesOnDelete) {
test_path = idb_context->GetFilePathForTesting(
webkit_database::GetIdentifierFromOrigin(kTestOrigin));
+ IndexedDBPendingConnection open_connection(open_callbacks,
+ open_db_callbacks,
+ 0 /* child_process_id */,
+ 0 /* host_transaction_id */,
+ 0 /* version */);
factory->Open(base::ASCIIToUTF16("opendb"),
- 0,
- 0,
- open_callbacks,
- open_db_callbacks,
+ open_connection,
kTestOrigin,
idb_context->data_path());
+ IndexedDBPendingConnection closed_connection(closed_callbacks,
+ closed_db_callbacks,
+ 0 /* child_process_id */,
+ 0 /* host_transaction_id */,
+ 0 /* version */);
factory->Open(base::ASCIIToUTF16("closeddb"),
- 0,
- 0,
- closed_callbacks,
- closed_db_callbacks,
+ closed_connection,
kTestOrigin,
idb_context->data_path());
@@ -247,13 +251,14 @@ TEST_F(IndexedDBTest, ForceCloseOpenDatabasesOnCommitFailure) {
scoped_refptr<MockIndexedDBDatabaseCallbacks> db_callbacks(
new MockIndexedDBDatabaseCallbacks());
const int64 transaction_id = 1;
- factory->Open(base::ASCIIToUTF16("db"),
- IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION,
- transaction_id,
- callbacks,
- db_callbacks,
- kTestOrigin,
- temp_dir.path());
+ IndexedDBPendingConnection connection(
+ callbacks,
+ db_callbacks,
+ 0 /* child_process_id */,
+ transaction_id,
+ IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+ factory->Open(
+ base::ASCIIToUTF16("db"), connection, kTestOrigin, temp_dir.path());
EXPECT_TRUE(callbacks->connection());
« no previous file with comments | « content/browser/indexed_db/indexed_db_pending_connection.cc ('k') | content/browser/indexed_db/leveldb/leveldb_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698