Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: content/browser/indexed_db/indexed_db_factory.cc

Issue 198223002: Added IndexedDBPendingConnection to group up a bunch of parameters that get (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge out Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_factory.cc
diff --git a/content/browser/indexed_db/indexed_db_factory.cc b/content/browser/indexed_db/indexed_db_factory.cc
index 5fec2a993abd6603e119d949f5ac634efcdc1d12..86af571319c65643c5a4acec2d533455f915c390 100644
--- a/content/browser/indexed_db/indexed_db_factory.cc
+++ b/content/browser/indexed_db/indexed_db_factory.cc
@@ -294,14 +294,10 @@ scoped_refptr<IndexedDBBackingStore> IndexedDBFactory::OpenBackingStore(
return 0;
}
-void IndexedDBFactory::Open(
- const base::string16& name,
- int64 version,
- int64 transaction_id,
- scoped_refptr<IndexedDBCallbacks> callbacks,
- scoped_refptr<IndexedDBDatabaseCallbacks> database_callbacks,
- const GURL& origin_url,
- const base::FilePath& data_directory) {
+void IndexedDBFactory::Open(const base::string16& name,
+ const IndexedDBPendingConnection& connection,
+ const GURL& origin_url,
+ const base::FilePath& data_directory) {
IDB_TRACE("IndexedDBFactory::Open");
scoped_refptr<IndexedDBDatabase> database;
IndexedDBDatabase::Identifier unique_identifier(origin_url, name);
@@ -320,14 +316,14 @@ void IndexedDBFactory::Open(
&disk_full);
if (!backing_store) {
if (disk_full) {
- callbacks->OnError(
+ connection.callbacks->OnError(
IndexedDBDatabaseError(blink::WebIDBDatabaseExceptionQuotaError,
ASCIIToUTF16(
"Encountered full disk while opening "
"backing store for indexedDB.open.")));
return;
}
- callbacks->OnError(IndexedDBDatabaseError(
+ connection.callbacks->OnError(IndexedDBDatabaseError(
blink::WebIDBDatabaseExceptionUnknownError,
ASCIIToUTF16(
"Internal error opening backing store for indexedDB.open.")));
@@ -337,7 +333,7 @@ void IndexedDBFactory::Open(
database =
IndexedDBDatabase::Create(name, backing_store, this, unique_identifier);
if (!database) {
- callbacks->OnError(IndexedDBDatabaseError(
+ connection.callbacks->OnError(IndexedDBDatabaseError(
blink::WebIDBDatabaseExceptionUnknownError,
ASCIIToUTF16(
"Internal error creating database backend for indexedDB.open.")));
@@ -348,10 +344,9 @@ void IndexedDBFactory::Open(
}
if (data_loss != blink::WebIDBDataLossNone)
- callbacks->OnDataLoss(data_loss, data_loss_message);
+ connection.callbacks->OnDataLoss(data_loss, data_loss_message);
- database->OpenConnection(
- callbacks, database_callbacks, transaction_id, version);
+ database->OpenConnection(connection);
if (!was_open && database->ConnectionCount() > 0) {
database_map_[unique_identifier] = database;
« no previous file with comments | « content/browser/indexed_db/indexed_db_factory.h ('k') | content/browser/indexed_db/indexed_db_factory_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698