content/browser/indexed_db/indexed_db_pending_connection.cc - Issue 198223002: Added IndexedDBPendingConnection to group up a bunch of parameters that get

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/indexed_db/indexed_db_pending_connection.cc

Issue 198223002: Added IndexedDBPendingConnection to group up a bunch of parameters that get (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add missing file. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/indexed_db/indexed_db_database_unittest.cc ('K') | « content/browser/indexed_db/indexed_db_pending_connection.h ('k') | content/browser/indexed_db/indexed_db_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/browser/indexed_db/indexed_db_pending_connection.h"

	6

	7 #include "content/browser/indexed_db/indexed_db_callbacks.h"

	8 #include "content/browser/indexed_db/indexed_db_database_callbacks.h"

	9

	10 namespace content {

	11

	12 IndexedDBPendingConnection::IndexedDBPendingConnection(

	13 scoped_refptr<IndexedDBCallbacks> callbacks_in,

	14 scoped_refptr<IndexedDBDatabaseCallbacks> database_callbacks_in,

	15 int child_process_id_in,

	16 int64 transaction_id_in,

	17 int64 version_in)

	18 : callbacks(callbacks_in),

	19 database_callbacks(database_callbacks_in),

	20 child_process_id(child_process_id_in),
	jsbell 2014/03/12 23:40:49 Dunno if it's worth it, but maybe DCHECK that chil Dunno if it's worth it, but maybe DCHECK that child_process_id is 0 for now, and later DCHECK that it's NOT 0 so we know we're passing it around correctly everywhere? (Tests could be -1.) - Again, dunno if it's worth it. ericu 2014/03/12 23:56:37 I'm not sure a 0-check really buys us anything. Th Show quoted text On 2014/03/12 23:40:49, jsbell wrote: > Dunno if it's worth it, but maybe DCHECK that child_process_id is 0 for now, and > later DCHECK that it's NOT 0 so we know we're passing it around correctly > everywhere? (Tests could be -1.) - Again, dunno if it's worth it. I'm not sure a 0-check really buys us anything. The later DCHECK makes sense to me though.
	21 transaction_id(transaction_id_in),

	22 version(version_in) {}

	23

	24 } // namespace content

OLD	NEW