Added IndexedDBPendingConnection to group up a bunch of parameters that get

content/browser/indexed_db/indexed_db_database_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_database.h"
 
 #include "base/auto_reset.h"
 #include "base/logging.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 41 matching lines @@
                                 backing_store,
                                 factory,
                                 IndexedDBDatabase::Identifier());
 
   EXPECT_FALSE(backing_store->HasOneRef());  // local and db
 
   scoped_refptr<MockIndexedDBCallbacks> request1(new MockIndexedDBCallbacks());
   scoped_refptr<MockIndexedDBDatabaseCallbacks> callbacks1(
       new MockIndexedDBDatabaseCallbacks());
   const int64 transaction_id1 = 1;
-  db->OpenConnection(request1,
-                     callbacks1,
-                     transaction_id1,
-                     IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+  IndexedDBPendingConnection connection1(
+      request1,
+      callbacks1,
+      0 /* fake child_process_id */,

[jsbell, 2014/03/12 23:40:49]

For consistency, make this a const int?

[ericu, 2014/03/12 23:56:37]

Done.

+      transaction_id1,
+      IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+  db->OpenConnection(connection1);
 
   EXPECT_FALSE(backing_store->HasOneRef());  // db, connection count > 0
 
   scoped_refptr<MockIndexedDBCallbacks> request2(new MockIndexedDBCallbacks());
   scoped_refptr<MockIndexedDBDatabaseCallbacks> callbacks2(
       new MockIndexedDBDatabaseCallbacks());
   const int64 transaction_id2 = 2;
-  db->OpenConnection(request2,
-                     callbacks2,
-                     transaction_id2,
-                     IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+  IndexedDBPendingConnection connection2(
+      request2,
+      callbacks2,
+      0 /* fake child_process_id */,
+      transaction_id2,
+      IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+  db->OpenConnection(connection2);
 
   EXPECT_FALSE(backing_store->HasOneRef());  // local and connection
 
   request1->connection()->ForceClose();
   EXPECT_FALSE(request1->connection()->IsConnected());
 
   EXPECT_FALSE(backing_store->HasOneRef());  // local and connection
 
   request2->connection()->ForceClose();
   EXPECT_FALSE(request2->connection()->IsConnected());
@@ skipping 15 matching lines @@
                                 backing_store,
                                 factory,
                                 IndexedDBDatabase::Identifier());
 
   EXPECT_FALSE(backing_store->HasOneRef());  // local and db
 
   scoped_refptr<MockIndexedDBDatabaseCallbacks> callbacks(
       new MockIndexedDBDatabaseCallbacks());
   scoped_refptr<MockIndexedDBCallbacks> request(new MockIndexedDBCallbacks());
   const int64 upgrade_transaction_id = 3;
-  database->OpenConnection(request,
-                           callbacks,
-                           upgrade_transaction_id,
-                           IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+  IndexedDBPendingConnection connection(
+      request,
+      callbacks,
+      0 /* fake child_process_id */,
+      upgrade_transaction_id,
+      IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+  database->OpenConnection(connection);
   EXPECT_EQ(database, request->connection()->database());
 
   const int64 transaction_id = 123;
   const std::vector<int64> scope;
   database->CreateTransaction(transaction_id,
                               request->connection(),
                               scope,
                               indexed_db::TRANSACTION_READ_ONLY);
 
   request->connection()->ForceClose();
@@ skipping 34 matching lines @@
                                 backing_store,
                                 factory,
                                 IndexedDBDatabase::Identifier());
 
   EXPECT_FALSE(backing_store->HasOneRef());  // local and db
 
   scoped_refptr<MockIndexedDBCallbacks> request1(new MockIndexedDBCallbacks());
   scoped_refptr<MockIndexedDBDatabaseCallbacks> callbacks1(
       new MockIndexedDBDatabaseCallbacks());
   const int64 transaction_id1 = 1;
-  db->OpenConnection(request1,
-                     callbacks1,
-                     transaction_id1,
-                     IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+  IndexedDBPendingConnection connection(
+      request1,
+      callbacks1,
+      0 /* fake child_process_id */,
+      transaction_id1,
+      IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+  db->OpenConnection(connection);
 
   EXPECT_FALSE(backing_store->HasOneRef());  // local and db
 
   scoped_refptr<MockDeleteCallbacks> request2(new MockDeleteCallbacks());
   db->DeleteDatabase(request2);
 
   EXPECT_TRUE(request2->blocked_called());
   EXPECT_FALSE(backing_store->HasOneRef());  // local and db
 
   db->Close(request1->connection(), true /* forced */);
 
   EXPECT_FALSE(db->backing_store());
   EXPECT_TRUE(backing_store->HasOneRef());  // local
 }
 
 }  // namespace content