Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1982213002: Revert of Add rudimentary shelf delegate mus unit test. (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
Reviewers:
msw, sadrul, sky
CC:
Ken Rockot(use gerrit already), chromium-reviews, James Cook, kalyank, mfomitchev
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add rudimentary shelf delegate mus unit test. (patchset #1 id:1 of https://codereview.chromium.org/1984723005/ ) Reason for revert: Hmm - still breaking stuff, but it doesn't look like hangs. Instead, crashes in tcmalloc via skia Original issue's description: > Reland of Add rudimentary shelf delegate mus unit test. (patchset #1 id:1 of https://codereview.chromium.org/1979103002/ ) > > Reason for revert: > Still need to wait until Friday before we can land https://codereview.chromium.org/1975073002 and be completely shutdown-race-free, but a few other lingering races have been fixed since this first landed. Going to attempt to reland and see if bots are happy. > > Original issue's description: > > Revert of Add rudimentary shelf delegate mus unit test. (patchset #6 id:180001 of https://codereview.chromium.org/1953893003/ ) > > > > Reason for revert: > > Boo, sorry, looks like they're timing out on the bot :( > > > > Original issue's description: > > > Add rudimentary shelf delegate mus unit test. > > > > > > Add simple mash shelf tests: > > > - ash_sysui (which hosts the shelf) draws a window. > > > - simple use of ShelfController/ShelfObserver interfaces. > > > > > > BUG=557406 > > > TEST=Tests pass > > > R=sky@chromium.org > > > > > > Committed: https://crrev.com/e3f59d3dfe3ec367a7ba4d2109d41fc6f2784088 > > > Cr-Commit-Position: refs/heads/master@{#393700} > > > > TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=557406 > > > > Committed: https://crrev.com/b63fb3d3eca89c99c2f387295f5d22ab32e6a650 > > Cr-Commit-Position: refs/heads/master@{#393763} > > TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=557406 > > Committed: https://crrev.com/0da14dbf44cbc97a525ee1d72a4faf4fd7798c29 > Cr-Commit-Position: refs/heads/master@{#393980} TBR=msw@chromium.org,sadrul@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557406 Committed: https://crrev.com/d721e1158e0cb308f4376b4a2867ec9c3607f48f Cr-Commit-Position: refs/heads/master@{#394046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -157 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D ash/mus/shelf_delegate_mus_unittest.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M mash/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/unittests_manifest.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ken Rockot(use gerrit already)
Created Revert of Add rudimentary shelf delegate mus unit test.
4 years, 7 months ago (2016-05-17 04:05:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982213002/1
4 years, 7 months ago (2016-05-17 04:05:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 04:06:07 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 04:07:24 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d721e1158e0cb308f4376b4a2867ec9c3607f48f
Cr-Commit-Position: refs/heads/master@{#394046}

Powered by Google App Engine
This is Rietveld 408576698