Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1982203003: [runtime] Fix effect of setting .prototype on generator functions. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Fix effect of setting .prototype on generator functions. When setting a generator function's "prototype" property to a non-object, the prototype of new generator instances should be %GeneratorPrototype%, not %ObjectPrototype%. R=verwaest@chromium.org BUG=v8:5011 Committed: https://crrev.com/3560d9bd583e79c981ef30f2767167219ba91bce Cr-Commit-Position: refs/heads/master@{#36313}

Patch Set 1 #

Patch Set 2 : ignition test rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +6 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-objects.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
neis
4 years, 7 months ago (2016-05-17 11:50:09 UTC) #1
Toon Verwaest
Do we want a DCHECK that the intrinsicDefaultProto of the incoming function matches one of ...
4 years, 7 months ago (2016-05-17 15:30:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982203003/20001
4 years, 7 months ago (2016-05-18 08:42:37 UTC) #4
neis
On 2016/05/17 15:30:08, Toon Verwaest wrote: > Do we want a DCHECK that the intrinsicDefaultProto ...
4 years, 7 months ago (2016-05-18 08:43:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 09:15:45 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 09:18:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3560d9bd583e79c981ef30f2767167219ba91bce
Cr-Commit-Position: refs/heads/master@{#36313}

Powered by Google App Engine
This is Rietveld 408576698