tools/json_schema_compiler/idl_schema.py - Issue 1982193002: Add enum class support to json_schema_compiler (idl files)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/idl_schema.py

Issue 1982193002: Add enum class support to json_schema_compiler (idl files) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: I accidentally a patchset dependency Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/idl_schema.py

diff --git a/tools/json_schema_compiler/idl_schema.py b/tools/json_schema_compiler/idl_schema.py

index 58efe28598f1660e9f4481e412f30fa715195668..d1d1541837e099058113dfb3ddef4d57ee2ce2ee 100755

--- a/tools/json_schema_compiler/idl_schema.py

+++ b/tools/json_schema_compiler/idl_schema.py

@@ -360,8 +360,10 @@ class Enum(object):

'description': self.description,

'type': 'string',

'enum': enum}

+ # TODO(tapted): Drop enum_class when it is the default.

+ # See http://crbug.com/612382.

for property_name in ('cpp_enum_prefix_override', 'inline_doc',

- 'noinline_doc', 'nodefine', 'nodoc',):

+ 'noinline_doc', 'nodefine', 'nodoc', 'enum_class',):

if self.node.GetProperty(property_name):

result[property_name] = self.node.GetProperty(property_name)

if self.node.GetProperty('deprecated'):

« no previous file with comments | « tools/json_schema_compiler/h_generator.py ('k') | tools/json_schema_compiler/model.py » ('j') | no next file with comments »