tools/json_schema_compiler/model.py - Issue 1982193002: Add enum class support to json_schema_compiler (idl files)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/model.py

Issue 1982193002: Add enum class support to json_schema_compiler (idl files) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enum -> enum_class, TODOs Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/model.py

diff --git a/tools/json_schema_compiler/model.py b/tools/json_schema_compiler/model.py

index e0147b5b4889fb2a86b59a74648a4deb24316051..518986510857e8c7f868fa259ed819cd74e3553a 100644

--- a/tools/json_schema_compiler/model.py

+++ b/tools/json_schema_compiler/model.py

@@ -210,6 +210,9 @@ class Type(object):

self.property_type = PropertyType.ENUM

self.enum_values = [EnumValue(value) for value in json['enum']]

self.cpp_enum_prefix_override = json.get('cpp_enum_prefix_override', None)

+ # TODO(tapted): Deprecate non-class enums, make is_class the default and

+ # delete the next line. See http://crbug.com/612382.

+ self.is_class = json.get('enum_class', False)

Devlin 2016/05/19 00:33:12 nit: here, too, I'd prefer this to be enum_class o

tapted 2016/05/19 12:22:33 Done.

elif json_type == 'any':

self.property_type = PropertyType.ANY

elif json_type == 'binary':