Add enum class support to json_schema_compiler (idl files)

tools/json_schema_compiler/test/idl_basics.idl

Index: tools/json_schema_compiler/test/idl_basics.idl
diff --git a/tools/json_schema_compiler/test/idl_basics.idl b/tools/json_schema_compiler/test/idl_basics.idl
index bfa49dce7f41e1d46bb5432bb8a9ca8676011108..555e8ebc2b8d4b8bd0733d5a0c9a5da364a24231 100644
--- a/tools/json_schema_compiler/test/idl_basics.idl
+++ b/tools/json_schema_compiler/test/idl_basics.idl
@@ -17,6 +17,21 @@
     name2
   };
 
+  [cpp_enum_prefix_override="prefix"] enum EnumWithPrefix {

[Devlin, 2016/05/17 19:04:10]

Do we want to support prefixes for vanilla enums?  What's the use case?

[tapted, 2016/05/18 09:35:54]

Ah, it's actually the prefixes for class-enums that I wasn't sure about :).
prefixes are used already in ax_enums.idl. E.g., there it has:

[cpp_enum_prefix_override="ax_attr"] enum AXStringAttribute {
    access_key,
  ...
}

[cpp_enum_prefix_override="ax_attr"] enum AXIntAttribute {
    scroll_x,
  ...
}

These generate

AX_ATTR_ACCESS_KEY
AX_ATTR_SCROLL_X


When these switch directly to enum classes, currently the approach will be

AXStringAttribute::AX_ATTR_ACCESS_KEY
AXIntAttribute::AX_ATTR_SCROLL_X


or the prefix could be removed to become

AXStringAttribute::ACCESS_KEY
AXIntAttribute::SCROLL_X


or -- depending how they're used -- we could merge them, and just have

AXAttr::ACCESS_KEY
AXAttr::SCROLL_X


But that might violate some use cases -- perhaps there is type matching for
overloads somewhere.


Perhaps for these it would make sense to keep them as non-class enums and turn
cpp_enum_prefix_override+enum_class into a hard error. For now I didn't really
add anything special, but just ensured it wouldn't fail. And if somewhere
there's a preference to have an additional FOO_ prefix on class enums too, then
that's supported.

+    name1,
+    name2
+  };
+
+  [class] enum EnumClass {
+    name1,
+    name2
+  };
+
+  [class,cpp_enum_prefix_override="prefix"] enum EnumClassWithPrefix {

[Devlin, 2016/05/17 19:04:10]

nit: cpp_enum_prefix_override is quite a mouthful.  Maybe just "prefix"? 
Conversely, [class] actually seems not-as-descriptive - maybe [use_class] or a
full [enum_class]?

These are just my opinions, and don't really affect all that much, so I'll leave
it up to you.

[tapted, 2016/05/18 09:35:54]

Yup I agree 'class' is a bit terse - went with enum_class.

changing cpp_enum_prefix_override would alter some idl files, so is a bit
orthogonal. (I just wanted to ensure there was some test coverage for this
existing use case :).

+    name1,
+    name2
+  };
+
   dictionary MyType1 {
     // This comment tests "double-quotes".
     [legalValues=(1,2)] long x;
@@ -31,6 +46,13 @@
     DOMString x;
   };
 
+  dictionary MyType3 {
+    EnumType w;
+    EnumWithPrefix x;
+    EnumClass y;
+    EnumClassWithPrefix z;
+  };
+
   dictionary UnionType {
     (EnumType or DOMString)? x;
     (DOMString or EnumType) y;