[Findit] Adding variable builders for Linux ChromiumOS Full and Win x64

[Findit] Adding variable builders for Linux ChromiumOS Full and Win x64

BUG=611527, 611804
Committed: https://chromium.googlesource.com/chromium/tools/build/+/63aa22156231a129fc53cb066ead3effb4a97f28

[lijeffrey, 2016-05-17 00:59:46]

Description was changed from

==========
[Findit] Adding variable builders for Linux ChromiumOS Full and Win x64

BUG=
==========

to

==========
[Findit] Adding variable builders for Linux ChromiumOS Full and Win x64

BUG=611527, 611804
==========

[lijeffrey, 2016-05-17 00:59:46]

lijeffrey@chromium.org changed reviewers:
+ iannucci@chromium.org, sergeyberezin@chromium.org

[lijeffrey, 2016-05-17 01:00:53]

Hey guys,

Adding another couple Findit variable builders for new bots on the main
waterfall. Ptal when you have the chance.

Thanks,
Jeff

[stgao, 2016-05-17 18:11:57]

stgao@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2016-05-17 18:11:58]

I guess we also want to add these new variable builders to
https://code.google.com/p/chromium/codesearch#chromium/src/tools/mb/mb_config...
as well.

[lijeffrey, 2016-05-25 02:05:09]

Can someone ptal?

One concern is there isn't a win10 pool yet at the moment, so the webkit win10
builder will actually be win7 underneath, does anyone know if that'll cause
problems in the meantime?

Thanks,
Jeff

[iannucci, 2016-05-25 19:45:13]

syntax lgtm, but I can't speak to capacity or win7/win10 equivalency

[Sergey Berezin, 2016-05-25 22:28:13]

I'm mainly concerned with disk space, since I don't think these builders will
have much traffic. There are a couple of slaves in the
master.tryserver.chromium.linux:linux_optional pool at 87% of disk usage:
http://shortn/_UkXybzRPmH

Since you're creating a new slavebuilddir, these bots will most likely go over
90% and raise alerts. I'd first investigate if the disk space is legitimately
used up on these bots (go/bug-a-trooper is your friend). It's possible you might
want to split it into a separate pool.

Windows builders look fine, except I've no idea about win7/win10 difference.

[lijeffrey, 2016-05-26 00:06:19]

Hey Sergey,

I've merged the build directories to save on disk space, ptal

Thanks,
Jeff

[Sergey Berezin, 2016-05-26 00:17:01]

LGTM, thanks!

[lijeffrey, 2016-05-26 00:19:43]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2016-05-26 00:19:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1982173002/#ps80001
(title: "Forgot one")

[commit-bot: I haz the power, 2016-05-26 00:19:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1982173002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1982173002/80001

[commit-bot: I haz the power, 2016-05-26 00:29:22]

Description was changed from

==========
[Findit] Adding variable builders for Linux ChromiumOS Full and Win x64

BUG=611527, 611804
==========

to

==========
[Findit] Adding variable builders for Linux ChromiumOS Full and Win x64

BUG=611527, 611804

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/63aa22156231a129fc53...
==========

[commit-bot: I haz the power, 2016-05-26 00:29:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/tools/build/+/63aa22156231a129fc53...