Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 198213008: Fix DCHECK caused by specifying a negative timestamp offset. (Closed)

Created:
6 years, 9 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 9 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Fix DCHECK caused by specifying a negative timestamp offset. Timestamp offsets are allowed to be negative, but a DCHECK in DoubleToDelta() was causing a crash in debug builds. This patch simply moves the "not negative" DCHECK to the methods that actually need to verify that constraint. BUG=353245 TEST=LayoutTest that verifies this fix is in https://codereview.chromium.org/202423002/. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/renderer/media/websourcebuffer_impl.cc View 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
acolwell GONE FROM CHROMIUM
6 years, 9 months ago (2014-03-17 19:33:41 UTC) #1
wolenetz
lgtm
6 years, 9 months ago (2014-03-17 20:11:49 UTC) #2
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-17 20:18:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/198213008/1
6 years, 9 months ago (2014-03-17 20:19:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 05:56:26 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-18 05:56:27 UTC) #6
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-18 16:16:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/198213008/1
6 years, 9 months ago (2014-03-18 16:17:28 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 16:24:04 UTC) #9
Message was sent while issue was closed.
Change committed as 257657

Powered by Google App Engine
This is Rietveld 408576698