Oilpan: Prepare to move AbstractSQLTransactionBackend, SQLTransactionBackend, and SQLTransactionCoo…

Source/modules/webdatabase/SQLTransactionCoordinator.h

Index: Source/modules/webdatabase/SQLTransactionCoordinator.h
diff --git a/Source/modules/webdatabase/SQLTransactionCoordinator.h b/Source/modules/webdatabase/SQLTransactionCoordinator.h
index 93ba4cda0aa20dd4ae587de307cd7e8474628f17..f783508f05e9e36203eba65fc56564de286233fb 100644
--- a/Source/modules/webdatabase/SQLTransactionCoordinator.h
+++ b/Source/modules/webdatabase/SQLTransactionCoordinator.h
@@ -32,6 +32,7 @@
 #ifndef SQLTransactionCoordinator_h
 #define SQLTransactionCoordinator_h
 
+#include "heap/Handle.h"
 #include "wtf/Deque.h"
 #include "wtf/HashMap.h"
 #include "wtf/HashSet.h"
@@ -50,15 +51,23 @@ public:
     void releaseLock(SQLTransactionBackend*);
     void shutdown();
 private:
-    typedef Deque<RefPtr<SQLTransactionBackend> > TransactionsQueue;
+    typedef Deque<RefPtrWillBeMember<SQLTransactionBackend> > TransactionsQueue;
     struct CoordinationInfo {
         TransactionsQueue pendingTransactions;
-        HashSet<RefPtr<SQLTransactionBackend> > activeReadTransactions;
-        RefPtr<SQLTransactionBackend> activeWriteTransaction;
+        WillBeHeapHashSet<RefPtrWillBeMember<SQLTransactionBackend> > activeReadTransactions;
+        RefPtrWillBeMember<SQLTransactionBackend> activeWriteTransaction;
+
+        void trace(Visitor* visitor)
+        {
+            visitor->trace(pendingTransactions);
+            visitor->trace(activeReadTransactions);
+            visitor->trace(activeWriteTransaction);
+        }
+        ALLOW_ONLY_INLINE_ALLOCATION();

[haraken, 2014/03/19 04:59:20]

Nit: We normally put this at the beginning of the struct:

struct CoordinationInfo {
  ALLOW_ONLY_INLINE_ALLOCATION();
public:
  ...;
};

     };
     // Maps database names to information about pending transactions
-    typedef HashMap<String, CoordinationInfo> CoordinationInfoMap;
-    CoordinationInfoMap m_coordinationInfoMap;
+    typedef WillBePersistentHeapHashMap<String, CoordinationInfo> CoordinationInfoHeapMap;

[haraken, 2014/03/19 04:59:20]

Mads, Erik: We don't need to add any Traits for CoordinationInfo when it's used
in a hash map, right?

c.f.: We need to define a VectorTrait if CoordinationInfo is used in a vector:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Mads Ager (chromium), 2014/03/19 06:30:54]

That is correct, you don't need the traits for HashMaps. They are needed for
Vectors of value objects to ensure that the value objects are not destructed
twice and we have made it a compilation error if the value object does not allow
initialization memset and copying with memcpy. For HashMaps we do not have that
issue because a HashMap knows if entries are deleted or empty values.

+    CoordinationInfoHeapMap m_coordinationInfoMap;
     bool m_isShuttingDown;
 
     void processPendingTransactions(CoordinationInfo&);