Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1982073002: Fix accessibility of buttons inside Chrome menu (Closed)

Created:
4 years, 7 months ago by dmazzoni
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix accessibility of buttons inside Chrome menu The Cut, Copy, Paste, Zoom In/Out, and Fullscreen buttons inside the Chrome menu aren't working with some Windows screen readers. Fix them by firing the same event (AX_EVENT_SELECTION internally) and using the same role (AX_ROLE_MENU_ITEM) for these buttons as for any other items within the menus. Internally we consider them to be "buttons", but since the keyboard behavior is to just linearize them, from an accessibility perspective it makes more sense to consider them to just be menu items. BUG=593392 Committed: https://crrev.com/19211b57d72c9f80763494278659f0b2322a8e75 Cr-Commit-Position: refs/heads/master@{#393956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M chrome/browser/ui/views/toolbar/app_menu.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dmazzoni
4 years, 7 months ago (2016-05-16 20:57:13 UTC) #2
sky
LGTM
4 years, 7 months ago (2016-05-16 21:15:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982073002/1
4 years, 7 months ago (2016-05-16 21:23:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 22:41:11 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 22:43:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19211b57d72c9f80763494278659f0b2322a8e75
Cr-Commit-Position: refs/heads/master@{#393956}

Powered by Google App Engine
This is Rietveld 408576698