Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1982043002: 👀 Cleanup DocumentMode migration helpers. (Closed)

Created:
4 years, 7 months ago by Peter Wen
Modified:
4 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup DocumentMode migration helpers. Remove DocumentMigrationHelper and DocumentModePreference. This helps to remove many dependencies on TabPersistentStore's methods. BUG=612245 Committed: https://crrev.com/5df8354b79028ebe02c4ac1ad911bc6e39037b8b Cr-Commit-Position: refs/heads/master@{#394109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -698 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMigrationHelper.java View 1 chunk +0 lines, -535 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModePreference.java View 1 chunk +0 lines, -135 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Wen
🎶 Let it go, let it go, the code never bothered me anyways (this is ...
4 years, 7 months ago (2016-05-16 20:04:06 UTC) #2
gone
Baby 👣. lgtm
4 years, 7 months ago (2016-05-16 20:10:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982043002/1
4 years, 7 months ago (2016-05-17 13:00:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 13:34:21 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 13:35:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5df8354b79028ebe02c4ac1ad911bc6e39037b8b
Cr-Commit-Position: refs/heads/master@{#394109}

Powered by Google App Engine
This is Rietveld 408576698