Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1982003002: Rename v0 custom element flags to V0 (Closed)

Created:
4 years, 7 months ago by kojii
Modified:
4 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename v0 custom element flags to V0 This patch renames flags for v0 custom element to have "V0" in their names, and the same changes to getter/setter of such flags, in order to distinguish them from flags for custom element v1. BUG=594918 Committed: https://crrev.com/495340a5749264cb14ea138bbeef237424cdbef6 Cr-Commit-Position: refs/heads/master@{#394004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kojii
PTAL. Two bots failing does not seem to be related.
4 years, 7 months ago (2016-05-16 23:09:53 UTC) #3
dominicc (has gone to gerrit)
lgtm
4 years, 7 months ago (2016-05-17 01:07:56 UTC) #5
haraken
owner LGTM
4 years, 7 months ago (2016-05-17 01:08:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982003002/1
4 years, 7 months ago (2016-05-17 01:08:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 01:18:51 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 01:20:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/495340a5749264cb14ea138bbeef237424cdbef6
Cr-Commit-Position: refs/heads/master@{#394004}

Powered by Google App Engine
This is Rietveld 408576698