Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: tools/dom/scripts/dartgenerator.py

Issue 19820007: Fixes for Blink roll. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Minors fixes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/dartgenerator.py
diff --git a/tools/dom/scripts/dartgenerator.py b/tools/dom/scripts/dartgenerator.py
index 8635eff719db6b0f94df2dca1726caad902ea343..5954d4e2c3b595187e78c4f76d2ec5c92b56ba70 100755
--- a/tools/dom/scripts/dartgenerator.py
+++ b/tools/dom/scripts/dartgenerator.py
@@ -86,7 +86,7 @@ class DartGenerator(object):
self._IsCompoundType(database, type_name)):
continue
# Ignore constructor warnings.
- if not (interface.id in ['DOMWindow', 'WorkerContext'] and
+ if not (interface.id in ['Window', 'WorkerContext'] and
type_name.endswith('Constructor')):
_logger.warn('removing %s in %s which has unidentified type %s' %
(node_name, interface.id, type_name))
@@ -213,6 +213,7 @@ class DartGenerator(object):
ARG = idlnode.IDLArgument([('Type', ('ScopedName', 'object')), ('Id', 'arg')])
for interface in database.GetInterfaces():
for operation in interface.operations:
- call_with = operation.ext_attrs.get('CallWith', '').split('|')
+ call_with = (operation.ext_attrs.get('CallWith', '').split('|') +
+ operation.ext_attrs.get('ConstructorCallWith', '').split('|'))
if 'ScriptArguments' in call_with:
operation.arguments.append(ARG)

Powered by Google App Engine
This is Rietveld 408576698