Issue 198193007: Isolated tests: mojo_js_unittests and mojo_apps_js_unittests

Issue 198193007: Isolated tests: mojo_js_unittests and mojo_apps_js_unittests (Closed)

Created:
6 years, 9 months ago by yzshen1

Modified:
6 years, 9 months ago

Reviewers:
viettrungluu, Paweł Hajdan Jr.

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Isolated tests: mojo_js_unittests and mojo_apps_js_unittests This CL lists the Windows dependencies. Mac and Linux dependencies will be in separate CLs. BUG=351214 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258078

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -3 lines)			Patch
M	mojo/mojo.gyp	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	mojo/mojo_apps.gypi	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
A	mojo/mojo_apps_js_unittests.isolate	View	1 2 3	1 chunk	+52 lines, -0 lines	0 comments	Download
A	mojo/mojo_js_unittests.isolate	View	1 2 3	1 chunk	+51 lines, -0 lines	0 comments	Download
M	mojo/mojo_public.gypi	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

yzshen1

Hi, Pawel and Trung. Would you please take a look? Thanks! Trung: OWNER Pawel: everything.

6 years, 9 months ago (2014-03-14 23:34:00 UTC) #1

viettrungluu

LGTM w/nits (but wait for Pawel). https://codereview.chromium.org/198193007/diff/40001/mojo/mojo_apps_js_unittests.isolate File mojo/mojo_apps_js_unittests.isolate (right): https://codereview.chromium.org/198193007/diff/40001/mojo/mojo_apps_js_unittests.isolate#newcode1 mojo/mojo_apps_js_unittests.isolate:1: # Copyright (c) ...

6 years, 9 months ago (2014-03-15 17:14:51 UTC) #2

yzshen1

Thanks Trung! https://codereview.chromium.org/198193007/diff/40001/mojo/mojo_apps_js_unittests.isolate File mojo/mojo_apps_js_unittests.isolate (right): https://codereview.chromium.org/198193007/diff/40001/mojo/mojo_apps_js_unittests.isolate#newcode1 mojo/mojo_apps_js_unittests.isolate:1: # Copyright (c) 2014 The Chromium Authors. ...

6 years, 9 months ago (2014-03-16 16:52:16 UTC) #3

yzshen1

Friendly ping, Pawel. (And also ping for the Linux and Mac dependency CLs.)

6 years, 9 months ago (2014-03-18 18:02:38 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/198193007/60001

6 years, 9 months ago (2014-03-19 18:01:09 UTC) #7

Message was sent while issue was closed.

Change committed as 258078

Expand Messages | Collapse Messages