runtime/lib/errors_patch.dart - Issue 19819003: Make reflective invocations raise NoSuchMethodErrors in the cases where non-reflective invocations …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/errors_patch.dart

Issue 19819003: Make reflective invocations raise NoSuchMethodErrors in the cases where non-reflective invocations … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/errors_patch.dart

===================================================================

--- runtime/lib/errors_patch.dart (revision 25346)

+++ runtime/lib/errors_patch.dart (working copy)

@@ -143,9 +143,13 @@

}

var args_mismatch = _existingArgumentNames != null;

StringBuffer msg_buf = new StringBuffer(_developerMessage(args_mismatch));

- String receiver_str = Error.safeToString(_receiver);

- if ("Type: class '::'" == receiver_str) {

+ String receiver_str;

+ var level = (_invocation_type >> _InvocationMirror._CALL_SHIFT) &

+ _InvocationMirror._CALL_MASK;

+ if ( level == _InvocationMirror._TOP_LEVEL) {

receiver_str = "top-level";

+ } else {

+ receiver_str = Error.safeToString(_receiver);

}

if (!args_mismatch) {

msg_buf.write(

« no previous file with comments | « no previous file | runtime/lib/mirrors.cc » ('j') | runtime/lib/mirrors.cc » ('J')