Source/core/html/HTMLFrameElementBase.cpp - Issue 198183003: Revert of id of iframe incorrectly sets window name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFrameElementBase.cpp

Issue 198183003: Revert of id of iframe incorrectly sets window name (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebaselined manually Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLFrameElementBase.cpp

diff --git a/Source/core/html/HTMLFrameElementBase.cpp b/Source/core/html/HTMLFrameElementBase.cpp

index 37b64ab10f67fb5bbde4f2ff90215927e55bdba5..f7e2290e5bfb70381c4f92e571edefc1c39cfd89 100644

--- a/Source/core/html/HTMLFrameElementBase.cpp

+++ b/Source/core/html/HTMLFrameElementBase.cpp

@@ -137,6 +137,8 @@ void HTMLFrameElementBase::parseAttribute(const QualifiedName& name, const Atomi

void HTMLFrameElementBase::setNameAndOpenURL()

{

m_frameName = getNameAttribute();

+ if (m_frameName.isNull())

+ m_frameName = getIdAttribute();

openURL();

}