third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp - Issue 1981823002: Remove OwnPtr::release() calls in platform/ (part 1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

Issue 1981823002: Remove OwnPtr::release() calls in platform/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

index bf6e341d702d1bc5f8d8e782b31c19f96d077e87..71ed10c30b260dc641b1105eec4cb3c113a83db7 100644

--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

@@ -103,7 +103,7 @@ public:

OwnPtr<MockImageDecoder> decoder = MockImageDecoder::create(this);

m_actualDecoder = decoder.get();

m_actualDecoder->setSize(1, 1);

- m_lazyDecoder = DeferredImageDecoder::createForTesting(decoder.release());

+ m_lazyDecoder = DeferredImageDecoder::createForTesting(std::move(decoder));

m_surface = SkSurface::MakeRasterN32Premul(100, 100);

ASSERT_TRUE(m_surface.get());

m_decodeRequestCount = 0;

@@ -361,7 +361,7 @@ TEST_F(DeferredImageDecoderTest, frameOpacity)

{

OwnPtr<ImageDecoder> actualDecoder = ImageDecoder::create(*m_data,

ImageDecoder::AlphaPremultiplied, ImageDecoder::GammaAndColorProfileApplied);

- OwnPtr<DeferredImageDecoder> decoder = DeferredImageDecoder::createForTesting(actualDecoder.release());

+ OwnPtr<DeferredImageDecoder> decoder = DeferredImageDecoder::createForTesting(std::move(actualDecoder));

decoder->setData(*m_data, true);

SkImageInfo pixInfo = SkImageInfo::MakeN32Premul(1, 1);