third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp - Issue 1981823002: Remove OwnPtr::release() calls in platform/ (part 1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp

Issue 1981823002: Remove OwnPtr::release() calls in platform/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/audio/Reverb.cpp ('k') | third_party/WebKit/Source/platform/exported/WebFileSystemCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp

diff --git a/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp b/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp

index 7113080a1455910a4ad117c6e6ce13e84aeb34d8..e204727165f989bc1dd2ecf8bf967de1231fd55d 100644

--- a/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp

+++ b/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp

@@ -93,10 +93,11 @@ ReverbConvolver::ReverbConvolver(AudioChannel* impulseResponse, size_t renderSli

bool isBackgroundStage = false;

if (useBackgroundThreads && stageOffset > RealtimeFrameLimit) {

- m_backgroundStages.append(stage.release());

+ m_backgroundStages.append(std::move(stage));

isBackgroundStage = true;

- } else

- m_stages.append(stage.release());

+ } else {

+ m_stages.append(std::move(stage));

+ }

stageOffset += stageSize;

++i;