Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: third_party/WebKit/Source/platform/TracedValueTest.cpp

Issue 1981823002: Remove OwnPtr::release() calls in platform/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/audio/FFTFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/TracedValueTest.cpp
diff --git a/third_party/WebKit/Source/platform/TracedValueTest.cpp b/third_party/WebKit/Source/platform/TracedValueTest.cpp
index 22e6d7c714e9e53e75cc47b75c04e9cc4b7de1e1..b2357545156c84e6755ee4c3a21ed7d5de4bd9ed 100644
--- a/third_party/WebKit/Source/platform/TracedValueTest.cpp
+++ b/third_party/WebKit/Source/platform/TracedValueTest.cpp
@@ -25,7 +25,7 @@ TEST(TracedValueTest, FlatDictionary)
value->setBoolean("bool", true);
value->setString("string", "string");
- std::unique_ptr<base::Value> parsed = parseTracedValue(value.release());
+ std::unique_ptr<base::Value> parsed = parseTracedValue(std::move(value));
base::DictionaryValue* dictionary;
ASSERT_TRUE(parsed->GetAsDictionary(&dictionary));
int intValue;
@@ -61,7 +61,7 @@ TEST(TracedValueTest, Hierarchy)
value->endArray();
value->setString("s0", "foo");
- std::unique_ptr<base::Value> parsed = parseTracedValue(value.release());
+ std::unique_ptr<base::Value> parsed = parseTracedValue(std::move(value));
base::DictionaryValue* dictionary;
ASSERT_TRUE(parsed->GetAsDictionary(&dictionary));
int i0;
@@ -109,7 +109,7 @@ TEST(TracedValueTest, Escape)
value->setString("s3\\", "value3");
value->setString("\"s4\"", "value4");
- std::unique_ptr<base::Value> parsed = parseTracedValue(value.release());
+ std::unique_ptr<base::Value> parsed = parseTracedValue(std::move(value));
base::DictionaryValue* dictionary;
ASSERT_TRUE(parsed->GetAsDictionary(&dictionary));
std::string s0;
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/audio/FFTFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698