Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/ImageDecodingStoreTest.cpp

Issue 1981823002: Remove OwnPtr::release() calls in platform/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 RefPtr<ImageFrameGenerator> m_generator; 78 RefPtr<ImageFrameGenerator> m_generator;
79 int m_decodersDestroyed; 79 int m_decodersDestroyed;
80 }; 80 };
81 81
82 TEST_F(ImageDecodingStoreTest, insertDecoder) 82 TEST_F(ImageDecodingStoreTest, insertDecoder)
83 { 83 {
84 const SkISize size = SkISize::Make(1, 1); 84 const SkISize size = SkISize::Make(1, 1);
85 OwnPtr<ImageDecoder> decoder = MockImageDecoder::create(this); 85 OwnPtr<ImageDecoder> decoder = MockImageDecoder::create(this);
86 decoder->setSize(1, 1); 86 decoder->setSize(1, 1);
87 const ImageDecoder* refDecoder = decoder.get(); 87 const ImageDecoder* refDecoder = decoder.get();
88 ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder.rele ase()); 88 ImageDecodingStore::instance().insertDecoder(m_generator.get(), std::move(de coder));
89 EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries()); 89 EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries());
90 EXPECT_EQ(4u, ImageDecodingStore::instance().memoryUsageInBytes()); 90 EXPECT_EQ(4u, ImageDecodingStore::instance().memoryUsageInBytes());
91 91
92 ImageDecoder* testDecoder; 92 ImageDecoder* testDecoder;
93 EXPECT_TRUE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), si ze, &testDecoder)); 93 EXPECT_TRUE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), si ze, &testDecoder));
94 EXPECT_TRUE(testDecoder); 94 EXPECT_TRUE(testDecoder);
95 EXPECT_EQ(refDecoder, testDecoder); 95 EXPECT_EQ(refDecoder, testDecoder);
96 ImageDecodingStore::instance().unlockDecoder(m_generator.get(), testDecoder) ; 96 ImageDecodingStore::instance().unlockDecoder(m_generator.get(), testDecoder) ;
97 EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries()); 97 EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries());
98 } 98 }
99 99
100 TEST_F(ImageDecodingStoreTest, evictDecoder) 100 TEST_F(ImageDecodingStoreTest, evictDecoder)
101 { 101 {
102 OwnPtr<ImageDecoder> decoder1 = MockImageDecoder::create(this); 102 OwnPtr<ImageDecoder> decoder1 = MockImageDecoder::create(this);
103 OwnPtr<ImageDecoder> decoder2 = MockImageDecoder::create(this); 103 OwnPtr<ImageDecoder> decoder2 = MockImageDecoder::create(this);
104 OwnPtr<ImageDecoder> decoder3 = MockImageDecoder::create(this); 104 OwnPtr<ImageDecoder> decoder3 = MockImageDecoder::create(this);
105 decoder1->setSize(1, 1); 105 decoder1->setSize(1, 1);
106 decoder2->setSize(2, 2); 106 decoder2->setSize(2, 2);
107 decoder3->setSize(3, 3); 107 decoder3->setSize(3, 3);
108 ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder1.rel ease()); 108 ImageDecodingStore::instance().insertDecoder(m_generator.get(), std::move(de coder1));
109 ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder2.rel ease()); 109 ImageDecodingStore::instance().insertDecoder(m_generator.get(), std::move(de coder2));
110 ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder3.rel ease()); 110 ImageDecodingStore::instance().insertDecoder(m_generator.get(), std::move(de coder3));
111 EXPECT_EQ(3, ImageDecodingStore::instance().cacheEntries()); 111 EXPECT_EQ(3, ImageDecodingStore::instance().cacheEntries());
112 EXPECT_EQ(56u, ImageDecodingStore::instance().memoryUsageInBytes()); 112 EXPECT_EQ(56u, ImageDecodingStore::instance().memoryUsageInBytes());
113 113
114 evictOneCache(); 114 evictOneCache();
115 EXPECT_EQ(2, ImageDecodingStore::instance().cacheEntries()); 115 EXPECT_EQ(2, ImageDecodingStore::instance().cacheEntries());
116 EXPECT_EQ(52u, ImageDecodingStore::instance().memoryUsageInBytes()); 116 EXPECT_EQ(52u, ImageDecodingStore::instance().memoryUsageInBytes());
117 117
118 evictOneCache(); 118 evictOneCache();
119 EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries()); 119 EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries());
120 EXPECT_EQ(36u, ImageDecodingStore::instance().memoryUsageInBytes()); 120 EXPECT_EQ(36u, ImageDecodingStore::instance().memoryUsageInBytes());
121 121
122 evictOneCache(); 122 evictOneCache();
123 EXPECT_FALSE(ImageDecodingStore::instance().cacheEntries()); 123 EXPECT_FALSE(ImageDecodingStore::instance().cacheEntries());
124 EXPECT_FALSE(ImageDecodingStore::instance().memoryUsageInBytes()); 124 EXPECT_FALSE(ImageDecodingStore::instance().memoryUsageInBytes());
125 } 125 }
126 126
127 TEST_F(ImageDecodingStoreTest, decoderInUseNotEvicted) 127 TEST_F(ImageDecodingStoreTest, decoderInUseNotEvicted)
128 { 128 {
129 OwnPtr<ImageDecoder> decoder1 = MockImageDecoder::create(this); 129 OwnPtr<ImageDecoder> decoder1 = MockImageDecoder::create(this);
130 OwnPtr<ImageDecoder> decoder2 = MockImageDecoder::create(this); 130 OwnPtr<ImageDecoder> decoder2 = MockImageDecoder::create(this);
131 OwnPtr<ImageDecoder> decoder3 = MockImageDecoder::create(this); 131 OwnPtr<ImageDecoder> decoder3 = MockImageDecoder::create(this);
132 decoder1->setSize(1, 1); 132 decoder1->setSize(1, 1);
133 decoder2->setSize(2, 2); 133 decoder2->setSize(2, 2);
134 decoder3->setSize(3, 3); 134 decoder3->setSize(3, 3);
135 ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder1.rel ease()); 135 ImageDecodingStore::instance().insertDecoder(m_generator.get(), std::move(de coder1));
136 ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder2.rel ease()); 136 ImageDecodingStore::instance().insertDecoder(m_generator.get(), std::move(de coder2));
137 ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder3.rel ease()); 137 ImageDecodingStore::instance().insertDecoder(m_generator.get(), std::move(de coder3));
138 EXPECT_EQ(3, ImageDecodingStore::instance().cacheEntries()); 138 EXPECT_EQ(3, ImageDecodingStore::instance().cacheEntries());
139 139
140 ImageDecoder* testDecoder; 140 ImageDecoder* testDecoder;
141 EXPECT_TRUE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), Sk ISize::Make(2, 2), &testDecoder)); 141 EXPECT_TRUE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), Sk ISize::Make(2, 2), &testDecoder));
142 142
143 evictOneCache(); 143 evictOneCache();
144 evictOneCache(); 144 evictOneCache();
145 evictOneCache(); 145 evictOneCache();
146 EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries()); 146 EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries());
147 EXPECT_EQ(16u, ImageDecodingStore::instance().memoryUsageInBytes()); 147 EXPECT_EQ(16u, ImageDecodingStore::instance().memoryUsageInBytes());
148 148
149 ImageDecodingStore::instance().unlockDecoder(m_generator.get(), testDecoder) ; 149 ImageDecodingStore::instance().unlockDecoder(m_generator.get(), testDecoder) ;
150 evictOneCache(); 150 evictOneCache();
151 EXPECT_FALSE(ImageDecodingStore::instance().cacheEntries()); 151 EXPECT_FALSE(ImageDecodingStore::instance().cacheEntries());
152 EXPECT_FALSE(ImageDecodingStore::instance().memoryUsageInBytes()); 152 EXPECT_FALSE(ImageDecodingStore::instance().memoryUsageInBytes());
153 } 153 }
154 154
155 TEST_F(ImageDecodingStoreTest, removeDecoder) 155 TEST_F(ImageDecodingStoreTest, removeDecoder)
156 { 156 {
157 const SkISize size = SkISize::Make(1, 1); 157 const SkISize size = SkISize::Make(1, 1);
158 OwnPtr<ImageDecoder> decoder = MockImageDecoder::create(this); 158 OwnPtr<ImageDecoder> decoder = MockImageDecoder::create(this);
159 decoder->setSize(1, 1); 159 decoder->setSize(1, 1);
160 const ImageDecoder* refDecoder = decoder.get(); 160 const ImageDecoder* refDecoder = decoder.get();
161 ImageDecodingStore::instance().insertDecoder(m_generator.get(), decoder.rele ase()); 161 ImageDecodingStore::instance().insertDecoder(m_generator.get(), std::move(de coder));
162 EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries()); 162 EXPECT_EQ(1, ImageDecodingStore::instance().cacheEntries());
163 EXPECT_EQ(4u, ImageDecodingStore::instance().memoryUsageInBytes()); 163 EXPECT_EQ(4u, ImageDecodingStore::instance().memoryUsageInBytes());
164 164
165 ImageDecoder* testDecoder; 165 ImageDecoder* testDecoder;
166 EXPECT_TRUE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), si ze, &testDecoder)); 166 EXPECT_TRUE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), si ze, &testDecoder));
167 EXPECT_TRUE(testDecoder); 167 EXPECT_TRUE(testDecoder);
168 EXPECT_EQ(refDecoder, testDecoder); 168 EXPECT_EQ(refDecoder, testDecoder);
169 ImageDecodingStore::instance().removeDecoder(m_generator.get(), testDecoder) ; 169 ImageDecodingStore::instance().removeDecoder(m_generator.get(), testDecoder) ;
170 EXPECT_FALSE(ImageDecodingStore::instance().cacheEntries()); 170 EXPECT_FALSE(ImageDecodingStore::instance().cacheEntries());
171 171
172 EXPECT_FALSE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), s ize, &testDecoder)); 172 EXPECT_FALSE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), s ize, &testDecoder));
173 } 173 }
174 174
175 } // namespace blink 175 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698