[Cronet] Use Context's ClassLoader to load Cronet

[Cronet] Use Context's ClassLoader to load Cronet

The ClassLoader from the Context should be used, not the one
from the CronetEngine class. This facilitates loading Cronet
from other Contexts, which in turn facilitates loading Cronet
API and impl from separate Contexts.

BUG=629299
Committed: https://crrev.com/a82b7bdd36583a0036e29ee5d1da7807df30c0e4
Cr-Commit-Position: refs/heads/master@{#407457}

[pauljensen, 2016-05-31 18:18:55]

Description was changed from

==========
[Cronet] Use the right ClassLoader to load Cronet

The ClassLoader from the Context should be used, not the one
from the CronetEngine class. This facilitates loading Cronet
from other Contexts.
==========

to

==========
[Cronet] Use Context's ClassLoader to load Cronet

The ClassLoader from the Context should be used, not the one
from the CronetEngine class. This facilitates loading Cronet
from other Contexts, which in turn facilitates loading Cronet
API and impl from separate Contexts.
==========

[kapishnikov, 2016-06-02 16:17:46]

kapishnikov@chromium.org changed reviewers:
+ kapishnikov@chromium.org

[kapishnikov, 2016-06-02 16:17:47]

https://codereview.chromium.org/1981793002/diff/80001/components/cronet/andro...
File components/cronet/android/api/src/org/chromium/net/CronetEngine.java
(right):

https://codereview.chromium.org/1981793002/diff/80001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/CronetEngine.java:1013:
builder.getContext()
Is it the same context that is supplied in the constructor of the Builder class?
We should expect that the user is going to construct the Builder with the app
context or the activity context.

[pauljensen, 2016-06-03 13:24:30]

https://codereview.chromium.org/1981793002/diff/80001/components/cronet/andro...
File components/cronet/android/api/src/org/chromium/net/CronetEngine.java
(right):

https://codereview.chromium.org/1981793002/diff/80001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/CronetEngine.java:1013:
builder.getContext()
On 2016/06/02 16:17:47, kapishnikov wrote:
> Is it the same context that is supplied in the constructor of the Builder
class?

Yes

> We should expect that the user is going to construct the Builder with the app
> context or the activity context.

As the API stands now, yes.  However I'm proposing having another method to
construct the CronetEngine.Builder, and potentially hiding the default
CronetEngine.Builder().

[pauljensen, 2016-07-21 13:24:53]

Andrei, would you like to review this?

[pauljensen, 2016-07-21 13:38:17]

Description was changed from

==========
[Cronet] Use Context's ClassLoader to load Cronet

The ClassLoader from the Context should be used, not the one
from the CronetEngine class. This facilitates loading Cronet
from other Contexts, which in turn facilitates loading Cronet
API and impl from separate Contexts.
==========

to

==========
[Cronet] Use Context's ClassLoader to load Cronet

The ClassLoader from the Context should be used, not the one
from the CronetEngine class. This facilitates loading Cronet
from other Contexts, which in turn facilitates loading Cronet
API and impl from separate Contexts.

BUG=629299
==========

[kapishnikov, 2016-07-22 20:48:46]

lgtm

[pauljensen, 2016-07-25 11:59:38]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2016-07-25 11:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 12:37:47]

Description was changed from

==========
[Cronet] Use Context's ClassLoader to load Cronet

The ClassLoader from the Context should be used, not the one
from the CronetEngine class. This facilitates loading Cronet
from other Contexts, which in turn facilitates loading Cronet
API and impl from separate Contexts.

BUG=629299
==========

to

==========
[Cronet] Use Context's ClassLoader to load Cronet

The ClassLoader from the Context should be used, not the one
from the CronetEngine class. This facilitates loading Cronet
from other Contexts, which in turn facilitates loading Cronet
API and impl from separate Contexts.

BUG=629299
==========

[commit-bot: I haz the power, 2016-07-25 12:37:48]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-25 12:39:28]

Description was changed from

==========
[Cronet] Use Context's ClassLoader to load Cronet

The ClassLoader from the Context should be used, not the one
from the CronetEngine class. This facilitates loading Cronet
from other Contexts, which in turn facilitates loading Cronet
API and impl from separate Contexts.

BUG=629299
==========

to

==========
[Cronet] Use Context's ClassLoader to load Cronet

The ClassLoader from the Context should be used, not the one
from the CronetEngine class. This facilitates loading Cronet
from other Contexts, which in turn facilitates loading Cronet
API and impl from separate Contexts.

BUG=629299

Committed: https://crrev.com/a82b7bdd36583a0036e29ee5d1da7807df30c0e4
Cr-Commit-Position: refs/heads/master@{#407457}
==========

[commit-bot: I haz the power, 2016-07-25 12:39:29]

Patchset 6 (id:??) landed as
https://crrev.com/a82b7bdd36583a0036e29ee5d1da7807df30c0e4
Cr-Commit-Position: refs/heads/master@{#407457}