Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1981773003: [ios] Protect JS messaging system from overriding window.webkit object. (Closed)

Created:
4 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 7 months ago
Reviewers:
Andy Caruso
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[ios] Protect JS messaging system from overriding window.webkit object. Any webpage can override window.webkit object (intentionally or by accident). Since window.webkit is used for JS->Native messaging it should be protected from overriding. Before sending a message, delete |window.webkit| to restore the original implementation. BUG=611023 Review-Url: https://codereview.chromium.org/1973683002 Cr-Commit-Position: refs/heads/master@{#393351} (cherry picked from commit 3eccc98ae84d9f47151d329b13fe2527f3f649ae) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/web/web_state/js/resources/message.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Eugene But (OOO till 7-30)
Cherry picked only fix. Tests depend on other CL which I don't think we should ...
4 years, 7 months ago (2016-05-16 15:23:32 UTC) #2
Andy Caruso
On 2016/05/16 15:23:32, Eugene But wrote: > Cherry picked only fix. Tests depend on other ...
4 years, 7 months ago (2016-05-16 19:49:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981773003/1
4 years, 7 months ago (2016-05-16 19:54:19 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 7 months ago (2016-05-16 19:54:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981773003/1
4 years, 7 months ago (2016-05-16 19:59:17 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:03:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698