check-webkit-style: Add checks for deprecated wtf/Assertions.h macros.

third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

 # -*- coding: utf-8; -*-
 #
 # Copyright (C) 2011 Google Inc. All rights reserved.
 # Copyright (C) 2009 Torch Mobile Inc.
 # Copyright (C) 2009 Apple Inc. All rights reserved.
 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
@@ skipping 1569 matching lines @@
              '  [whitespace/parens] [4]',
              'Consider using EXPECT_LT instead of EXPECT_TRUE(a < b)'
              '  [readability/check] [2]'])
         self.assert_lint(
             'CHECK("foo" == "foo")',
             'Consider using CHECK_EQ instead of CHECK(a == b)'
             '  [readability/check] [2]')
 
         self.assert_lint('CHECK_EQ("foo", "foo")', '')
 
+    def test_check_deprecated_macros(self):
+        self.assert_lint('ASSERT(foo)', 'ASSERT is deprecated. Use DCHECK or '
+                         'its variants instead.  [build/deprecated] [5]')
+        self.assert_lint('    ASSERT_UNUSED(foo, foo)', 'ASSERT_UNUSED is '
+                         'deprecated. Use DCHECK or its variants instead.  '
+                         '[build/deprecated] [5]')
+        self.assert_lint('ASSERT_NOT_REACHED()', 'ASSERT_NOT_REACHED is '
+                         'deprecated. Use NOTREACHED instead.  '
+                         '[build/deprecated] [5]')
+        self.assert_lint('ASSERT_WITH_SECURITY_IMPLICATION(foo)',
+                         'ASSERT_WITH_SECURITY_IMPLICATION is deprecated. Use '
+                         'SECURITY_DCHECK instead.  [build/deprecated] [5]')
+        self.assert_lint('WTF_LOG(foo)', 'WTF_LOG is deprecated. Use DVLOG '
+                         'instead.  [build/deprecated] [5]')
+
+        self.assert_lint('FOO_BAR_ASSERT()', '')
+        self.assert_lint('ASSERT_NO_EXCEPTIONS', '')
+
     def test_brace_at_begin_of_line(self):
         self.assert_lint('{',
                          'This { should be at the end of the previous line'
                          '  [whitespace/braces] [4]')
         self.assert_multi_line_lint(
             '#endif\n'
             '{\n'
             '}\n',
             '')
         self.assert_multi_line_lint(
@@ skipping 1780 matching lines @@
                 class Foo::Goo {
                     virtual ~Goo();
                     virtual void goo();
                 };''',
             '')
         self.assert_multi_line_lint(
             'class Foo { void foo(); };',
             'More than one command on the same line  [whitespace/newline] [4]')
         self.assert_multi_line_lint(
             'class MyClass {\n'
-            '    int getIntValue() { ASSERT(m_ptr); return *m_ptr; }\n'
+            '    int getIntValue() { DCHECK(m_ptr); return *m_ptr; }\n'
             '};\n',
             '')
         self.assert_multi_line_lint(
             'class MyClass {\n'
             '    int getIntValue()\n'
             '    {\n'
-            '        ASSERT(m_ptr); return *m_ptr;\n'
+            '        DCHECK(m_ptr); return *m_ptr;\n'
             '    }\n'
             '};\n',
             'More than one command on the same line  [whitespace/newline] [4]')
 
         self.assert_multi_line_lint(
             '''\
                 class Qualified::Goo : public Foo {
                     virtual void goo();
                 };''',
             '')
@@ skipping 1852 matching lines @@
     def test_ne(self):
         """Test __ne__ inequality function."""
         checker1 = self._checker()
         checker2 = self._checker()
 
         # != calls __ne__.
         # By default, __ne__ always returns true on different objects.
         # Thus, just check the distinguishing case to verify that the
         # code defines __ne__.
         self.assertFalse(checker1 != checker2)