Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: media/cdm/ppapi/ppapi_cdm_adapter.gni

Issue 1981723002: media: Set RUNPATH in cdm adapter in GN component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This template defines a CDM adapter target. Just use this as you would a 5 # This template defines a CDM adapter target. Just use this as you would a
6 # normal target and everything should work correctly. If GYP, you would instead 6 # normal target and everything should work correctly. If GYP, you would instead
7 # depend on media/media_cdm_adapter.gyp:cdmadapter which would in turn modify 7 # depend on media/media_cdm_adapter.gyp:cdmadapter which would in turn modify
8 # your target with direct_dependent_settings. 8 # your target with direct_dependent_settings.
9 template("ppapi_cdm_adapter") { 9 template("ppapi_cdm_adapter") {
10 if (is_mac || is_linux) { 10 if (is_mac || is_linux) {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 ] 52 ]
53 53
54 output_extension = "plugin" 54 output_extension = "plugin"
55 } else if (is_posix) { 55 } else if (is_posix) {
56 cflags += [ "-fvisibility=hidden" ] 56 cflags += [ "-fvisibility=hidden" ]
57 57
58 # Required for clock_gettime() 58 # Required for clock_gettime()
59 libs += [ "rt" ] 59 libs += [ "rt" ]
60 } 60 }
61 61
62 if (is_linux && !is_component_build) { 62 if (is_linux) {
63 # CDM adapter depends on a CDM even in non-component builds. 63 # CDM adapter depends on a CDM in component and non-component builds.
64 configs += [ "//build/config/gcc:rpath_for_built_shared_libraries" ] 64 configs += [ "//build/config/gcc:rpath_for_built_shared_libraries" ]
ddorwin 2016/05/16 18:11:12 I know we need to set rpath for the adapter, but t
xhwang 2016/05/16 18:23:07 This was discussed when we added this back. See ht
ddorwin 2016/05/16 18:28:46 thestig@: Should we update the documentation in th
Lei Zhang 2016/05/17 20:31:15 Meh. The config("executable_ldconfig") section in
65 } 65 }
66 66
67 # TODO(jschuh) crbug.com/167187 67 # TODO(jschuh) crbug.com/167187
68 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 68 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
69 } 69 }
70 } 70 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698