Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1981633002:
Change VideoTrackRecorder to operate on a given task runner (Closed)
|
Created:
4 years, 7 months ago by emircan Modified:
4 years, 7 months ago Reviewers:
mcasas CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange VideoTrackRecorder to operate on a given task runner
This CL modified VideoTrackRecorder so that it can perform encoding
interactions on a given task runner. This change is necessary since VEA
operations happen on a given task runner from GpuFactories.
This CL is [1 of 2] to add support for Video Encode Accelerator in
VideoTrackRecorder.
Playground CL: https://codereview.chromium.org/1934093002/
BUG=608385
TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html
Committed: https://crrev.com/66b5ab718cb4cf10180e2ce458dbddd9db300a25
Cr-Commit-Position: refs/heads/master@{#393913}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #Messages
Total messages: 14 (8 generated)
Description was changed from ========== new interface. BUG= ========== to ========== Change VideoTrackRecorder to operate on a given task runner This CL modified VideoTrackRecorder so that it can perform encoding interactions on a given task runner. This change is necessary since VEA operations happen on a given task runner from GpuFactories. This CL is [1 of 2] to add support for Video Encode Accelerator in VideoTrackRecorder. Playground CL:https://codereview.chromium.org/1934093002/ BUG=608385 ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
PTAL.
Description was changed from ========== Change VideoTrackRecorder to operate on a given task runner This CL modified VideoTrackRecorder so that it can perform encoding interactions on a given task runner. This change is necessary since VEA operations happen on a given task runner from GpuFactories. This CL is [1 of 2] to add support for Video Encode Accelerator in VideoTrackRecorder. Playground CL:https://codereview.chromium.org/1934093002/ BUG=608385 ========== to ========== Change VideoTrackRecorder to operate on a given task runner This CL modified VideoTrackRecorder so that it can perform encoding interactions on a given task runner. This change is necessary since VEA operations happen on a given task runner from GpuFactories. This CL is [1 of 2] to add support for Video Encode Accelerator in VideoTrackRecorder. Playground CL:https://codereview.chromium.org/1934093002/ BUG=608385 TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html ==========
Description was changed from ========== Change VideoTrackRecorder to operate on a given task runner This CL modified VideoTrackRecorder so that it can perform encoding interactions on a given task runner. This change is necessary since VEA operations happen on a given task runner from GpuFactories. This CL is [1 of 2] to add support for Video Encode Accelerator in VideoTrackRecorder. Playground CL:https://codereview.chromium.org/1934093002/ BUG=608385 TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html ========== to ========== Change VideoTrackRecorder to operate on a given task runner This CL modified VideoTrackRecorder so that it can perform encoding interactions on a given task runner. This change is necessary since VEA operations happen on a given task runner from GpuFactories. This CL is [1 of 2] to add support for Video Encode Accelerator in VideoTrackRecorder. Playground CL: https://codereview.chromium.org/1934093002/ BUG=608385 TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html ==========
lgtm https://codereview.chromium.org/1981633002/diff/1/content/renderer/media/vide... File content/renderer/media/video_track_recorder.cc (right): https://codereview.chromium.org/1981633002/diff/1/content/renderer/media/vide... content/renderer/media/video_track_recorder.cc:65: if (!encoding_thread_) { if (encoding_task_runner_) return; ?
https://codereview.chromium.org/1981633002/diff/1/content/renderer/media/vide... File content/renderer/media/video_track_recorder.cc (right): https://codereview.chromium.org/1981633002/diff/1/content/renderer/media/vide... content/renderer/media/video_track_recorder.cc:65: if (!encoding_thread_) { On 2016/05/14 01:31:08, mcasas wrote: > if (encoding_task_runner_) > return; > > ? Done.
The CQ bit was checked by emircan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org Link to the patchset: https://codereview.chromium.org/1981633002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981633002/20001
Message was sent while issue was closed.
Description was changed from ========== Change VideoTrackRecorder to operate on a given task runner This CL modified VideoTrackRecorder so that it can perform encoding interactions on a given task runner. This change is necessary since VEA operations happen on a given task runner from GpuFactories. This CL is [1 of 2] to add support for Video Encode Accelerator in VideoTrackRecorder. Playground CL: https://codereview.chromium.org/1934093002/ BUG=608385 TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html ========== to ========== Change VideoTrackRecorder to operate on a given task runner This CL modified VideoTrackRecorder so that it can perform encoding interactions on a given task runner. This change is necessary since VEA operations happen on a given task runner from GpuFactories. This CL is [1 of 2] to add support for Video Encode Accelerator in VideoTrackRecorder. Playground CL: https://codereview.chromium.org/1934093002/ BUG=608385 TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Change VideoTrackRecorder to operate on a given task runner This CL modified VideoTrackRecorder so that it can perform encoding interactions on a given task runner. This change is necessary since VEA operations happen on a given task runner from GpuFactories. This CL is [1 of 2] to add support for Video Encode Accelerator in VideoTrackRecorder. Playground CL: https://codereview.chromium.org/1934093002/ BUG=608385 TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html ========== to ========== Change VideoTrackRecorder to operate on a given task runner This CL modified VideoTrackRecorder so that it can perform encoding interactions on a given task runner. This change is necessary since VEA operations happen on a given task runner from GpuFactories. This CL is [1 of 2] to add support for Video Encode Accelerator in VideoTrackRecorder. Playground CL: https://codereview.chromium.org/1934093002/ BUG=608385 TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html Committed: https://crrev.com/66b5ab718cb4cf10180e2ce458dbddd9db300a25 Cr-Commit-Position: refs/heads/master@{#393913} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/66b5ab718cb4cf10180e2ce458dbddd9db300a25 Cr-Commit-Position: refs/heads/master@{#393913} |
