trunk/src/content/browser/webui/web_ui_impl.cc - Issue 198163004: Revert 257524 "Move IsStringASCII/UTF8 to base namespace."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/content/browser/webui/web_ui_impl.cc

Issue 198163004: Revert 257524 "Move IsStringASCII/UTF8 to base namespace." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/src/content/browser/storage_partition_impl_map.cc ('k') | trunk/src/content/child/ftp_directory_listing_response_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/src/content/browser/webui/web_ui_impl.cc

===================================================================

--- trunk/src/content/browser/webui/web_ui_impl.cc (revision 257532)

+++ trunk/src/content/browser/webui/web_ui_impl.cc (working copy)

@@ -140,14 +140,14 @@

}

void WebUIImpl::CallJavascriptFunction(const std::string& function_name) {

- DCHECK(base::IsStringASCII(function_name));

+ DCHECK(IsStringASCII(function_name));

base::string16 javascript = base::ASCIIToUTF16(function_name + "();");

ExecuteJavascript(javascript);

}

void WebUIImpl::CallJavascriptFunction(const std::string& function_name,

const base::Value& arg) {

- DCHECK(base::IsStringASCII(function_name));

+ DCHECK(IsStringASCII(function_name));

std::vector<const base::Value*> args;

args.push_back(&arg);

ExecuteJavascript(GetJavascriptCall(function_name, args));

@@ -156,7 +156,7 @@

void WebUIImpl::CallJavascriptFunction(

const std::string& function_name,

const base::Value& arg1, const base::Value& arg2) {

- DCHECK(base::IsStringASCII(function_name));

+ DCHECK(IsStringASCII(function_name));

std::vector<const base::Value*> args;

args.push_back(&arg1);

args.push_back(&arg2);

@@ -166,7 +166,7 @@

void WebUIImpl::CallJavascriptFunction(

const std::string& function_name,

const base::Value& arg1, const base::Value& arg2, const base::Value& arg3) {

- DCHECK(base::IsStringASCII(function_name));

+ DCHECK(IsStringASCII(function_name));

std::vector<const base::Value*> args;

args.push_back(&arg1);

args.push_back(&arg2);

@@ -180,7 +180,7 @@

const base::Value& arg2,

const base::Value& arg3,

const base::Value& arg4) {

- DCHECK(base::IsStringASCII(function_name));

+ DCHECK(IsStringASCII(function_name));

std::vector<const base::Value*> args;

args.push_back(&arg1);

args.push_back(&arg2);

@@ -192,7 +192,7 @@

void WebUIImpl::CallJavascriptFunction(

const std::string& function_name,

const std::vector<const base::Value*>& args) {

- DCHECK(base::IsStringASCII(function_name));

+ DCHECK(IsStringASCII(function_name));

ExecuteJavascript(GetJavascriptCall(function_name, args));

}