Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: services/navigation/navigation_unittest.cc

Issue 1981623002: Add a basic browser to mash that uses the navigation service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/navigation/navigation_unittest.cc
diff --git a/services/navigation/navigation_unittest.cc b/services/navigation/navigation_unittest.cc
index 7e14b2011940d8bc3668f6a02df4d36038ae2bcc..8ababd230279710597d1f33b54ab89e58c9add92 100644
--- a/services/navigation/navigation_unittest.cc
+++ b/services/navigation/navigation_unittest.cc
@@ -41,6 +41,14 @@ class NavigationTest : public shell::test::ShellTest,
if (++load_count_ == 2 && loop_)
loop_->Quit();
}
+ void NavigationStateChanged(const GURL& url,
+ const mojo::String& title,
+ bool can_go_back,
+ bool can_go_forward) override {}
+ void LoadProgressChanged(double progress) override {}
+ void ViewCreated(mojom::ViewPtr, mojom::ViewClientRequest, bool,
+ mojo::RectPtr, bool) override {}
+ void Close() override {}
int load_count_ = 0;
mojo::Binding<mojom::ViewClient> binding_;
@@ -50,13 +58,13 @@ class NavigationTest : public shell::test::ShellTest,
DISALLOW_COPY_AND_ASSIGN(NavigationTest);
};
-TEST_F(NavigationTest, LoadURL) {
+TEST_F(NavigationTest, Navigate) {
mojom::ViewFactoryPtr view_factory;
connector()->ConnectToInterface("exe:navigation", &view_factory);
mojom::ViewPtr view;
view_factory->CreateView(GetViewClient(), GetProxy(&view));
- view->LoadUrl(GURL("about:blank"));
+ view->NavigateTo(GURL("about:blank"));
base::RunLoop loop;
QuitOnLoadingStateChange(&loop);

Powered by Google App Engine
This is Rietveld 408576698