Issue 1981623002: Add a basic browser to mash that uses the navigation service.

Issue 1981623002: Add a basic browser to mash that uses the navigation service. (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)

Modified:
4 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add a basic browser to mash that uses the navigation service. BUG= Committed: https://crrev.com/e3b1f30ab13ff0e1ed64ee8dc4d38fe5f1702f91 Cr-Commit-Position: refs/heads/master@{#394037} Committed: https://crrev.com/f17dbf703deb84e7f83b84c16042fb069229a407 Cr-Commit-Position: refs/heads/master@{#394175}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 10

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+797 lines, -21 lines)			Patch
M	mash/BUILD.gn	View	1 2 3 4 5 6 7 8 9 10 12	1 chunk	+9 lines, -0 lines	0 comments	Download
A	mash/browser/BUILD.gn	View	1 2 3 4 5 6 7 8	1 chunk	+63 lines, -0 lines	0 comments	Download
A	mash/browser/DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	mash/browser/browser.h	View	1 2 3 4 5 6 7	1 chunk	+64 lines, -0 lines	0 comments	Download
A	mash/browser/browser.cc	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+376 lines, -0 lines	0 comments	Download
A	mash/browser/main.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	mash/browser/manifest.json	View	1 2 3 4 5 6	1 chunk	+11 lines, -0 lines	0 comments	Download
M	services/navigation/BUILD.gn	View	1 2 3 4 5	3 chunks	+43 lines, -0 lines	0 comments	Download
M	services/navigation/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	services/navigation/content_client/browser_main_parts.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	services/navigation/content_client/main_delegate.cc	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -0 lines	0 comments	Download
M	services/navigation/manifest.json	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	services/navigation/navigation.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	services/navigation/navigation.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	services/navigation/navigation_unittest.cc	View	1 2 3 4 5 6 7	2 chunks	+13 lines, -2 lines	0 comments	Download
M	services/navigation/public/interfaces/BUILD.gn	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+2 lines, -0 lines	0 comments	Download
M	services/navigation/public/interfaces/view.mojom	View	1 2 3 4 5	2 chunks	+24 lines, -1 line	0 comments	Download
M	services/navigation/view_impl.h	View	1 2 3 4 5	3 chunks	+45 lines, -3 lines	0 comments	Download
M	services/navigation/view_impl.cc	View	1 2 3 4 5 6 7	1 chunk	+111 lines, -8 lines	0 comments	Download
M	ui/views/mus/native_widget_mus.cc	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 25 (12 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sky

https://codereview.chromium.org/1981623002/diff/120001/mash/browser/browser.cc File mash/browser/browser.cc (right): https://codereview.chromium.org/1981623002/diff/120001/mash/browser/browser.cc#newcode39 mash/browser/browser.cc:39: class AuraInit; You shouldn't need to forward declare this ...

4 years, 7 months ago (2016-05-16 15:31:58 UTC) #3

Ben Goodger (Google)

On 2016/05/16 15:31:58, sky wrote: > https://codereview.chromium.org/1981623002/diff/120001/mash/browser/browser.cc > File mash/browser/browser.cc (right): > > https://codereview.chromium.org/1981623002/diff/120001/mash/browser/browser.cc#newcode39 > ...

4 years, 7 months ago (2016-05-16 18:02:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981623002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981623002/200001

4 years, 7 months ago (2016-05-16 23:24:28 UTC) #8

commit-bot: I haz the power

Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/229870)

4 years, 7 months ago (2016-05-16 23:58:11 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981623002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981623002/220001

4 years, 7 months ago (2016-05-17 01:42:32 UTC) #13

commit-bot: I haz the power

Patchset 12 (id:??) landed as https://crrev.com/e3b1f30ab13ff0e1ed64ee8dc4d38fe5f1702f91 Cr-Commit-Position: refs/heads/master@{#394037}

4 years, 7 months ago (2016-05-17 03:14:17 UTC) #16

James Cook

A revert of this CL (patchset #12 id:220001) has been created in https://codereview.chromium.org/1986003002/ by jamescook@chromium.org. ...

4 years, 7 months ago (2016-05-17 04:06:33 UTC) #17

Message was sent while issue was closed.

A revert of this CL (patchset #12 id:220001) has been created in
https://codereview.chromium.org/1986003002/ by jamescook@chromium.org.

The reason for reverting is: Seems to have broken Linux compile:

Automatically closing tree for "compile" on "Linux Builder"

http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/66451

FAILED:
obj/services/navigation/public/interfaces/interfaces_cpp_sources/view.mojom.o 
/b/build/slave/cache/cipd/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/services/navigation/public/interfaces/interfaces_cpp_sources/view.mojom.o.d
-DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS
-DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1
-DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_TOPCHROME_MD=1 -DFULL_SAFE_BROWSING
-DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD
-DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-DCR_CLANG_REVISION=268813-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen
-I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0
-I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables
-fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin
-fcolor-diagnostics -fdebug-prefix-map=/b/build/slave/Linux_Builder/build/src=.
-pthread -m64 -march=x86-64 -Wall -Werror -Wextra
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template -O2 -fno-ident
-fdata-sections -ffunction-sections -g0
--sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden
-Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs
-Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang
follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang
check-implicit-copy-ctors -Xclang -plugin-arg-find-bad-constructs -Xclang
check-ipc -Wheader-hygiene -Wstring-conversion -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c
gen/services/navigation/public/interfaces/view.mojom.cc -o
obj/services/navigation/public/interfaces/interfaces_cpp_sources/view.mojom.o
In file included from
gen/services/navigation/public/interfaces/view.mojom.cc:15:
In file included from gen/services/navigation/public/interfaces/view.mojom.h:29:
gen/services/navigation/public/interfaces/view.mojom-internal.h:14:10: fatal
error: 'components/mus/public/interfaces/window_tree.mojom-internal.h' file not
found
#include "components/mus/public/interfaces/window_tree.mojom-internal.h"
         ^
1 error generated.
.

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981623002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981623002/240001

4 years, 7 months ago (2016-05-17 17:24:45 UTC) #21

commit-bot: I haz the power

4 years, 7 months ago (2016-05-17 18:50:13 UTC) #25

Message was sent while issue was closed.

Patchset 13 (id:??) landed as
https://crrev.com/f17dbf703deb84e7f83b84c16042fb069229a407
Cr-Commit-Position: refs/heads/master@{#394175}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages