Fix GCC warnings to be ready for GCC standalone build

Fix GCC warnings to be ready for GCC standalone build

ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.

One warning is about maybe using uninitialized variable, the other is
about enum and non-enum in a conditional statement.

Committed: https://pdfium.googlesource.com/pdfium/+/01e624fb699af3a8ee2f81620d59d366dac18f29

[Wei Li, 2016-05-13 21:44:32]

Description was changed from

==========
Fix the GCC warning to be ready for GCC standalone build

ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.
==========

to

==========
Fix GCC warnings to be ready for GCC standalone build

ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.
==========

[Wei Li, 2016-05-13 21:44:32]

weili@chromium.org changed reviewers:
+ thestig@chromium.org

[Wei Li, 2016-05-13 21:46:09]

Description was changed from

==========
Fix GCC warnings to be ready for GCC standalone build

ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.
==========

to

==========
Fix GCC warnings to be ready for GCC standalone build

ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.

One warning is about maybe using uninitialized variable, the other is about enum
and non-enum in a conditional statement.
==========

[Wei Li, 2016-05-13 21:46:22]

Description was changed from

==========
Fix GCC warnings to be ready for GCC standalone build

ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.

One warning is about maybe using uninitialized variable, the other is about enum
and non-enum in a conditional statement.
==========

to

==========
Fix GCC warnings to be ready for GCC standalone build

ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.

One warning is about maybe using uninitialized variable, the other is
about enum and non-enum in a conditional statement.
==========

[Wei Li, 2016-05-13 21:46:36]

for review, thanks

[Lei Zhang, 2016-05-13 21:52:17]

https://codereview.chromium.org/1981593002/diff/1/third_party/agg23/0001-gcc-...
File third_party/agg23/0001-gcc-warning.patch (right):

https://codereview.chromium.org/1981593002/diff/1/third_party/agg23/0001-gcc-...
third_party/agg23/0001-gcc-warning.patch:9: -                   path_cmd_stop;
This doesn't match the actual change. Regenerate the patch?

[Wei Li, 2016-05-13 23:17:28]

Patchset #2 (id:20001) has been deleted

[Wei Li, 2016-05-13 23:22:34]

forgot to update after formatting, thanks for catching that.

https://codereview.chromium.org/1981593002/diff/1/third_party/agg23/0001-gcc-...
File third_party/agg23/0001-gcc-warning.patch (right):

https://codereview.chromium.org/1981593002/diff/1/third_party/agg23/0001-gcc-...
third_party/agg23/0001-gcc-warning.patch:9: -                   path_cmd_stop;
On 2016/05/13 21:52:16, Lei Zhang wrote:
> This doesn't match the actual change. Regenerate the patch?

Done.

[Lei Zhang, 2016-05-13 23:23:48]

lgtm

[Wei Li, 2016-05-13 23:41:48]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-05-13 23:41:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1981593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1981593002/40001

[commit-bot: I haz the power, 2016-05-13 23:59:53]

Description was changed from

==========
Fix GCC warnings to be ready for GCC standalone build

ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.

One warning is about maybe using uninitialized variable, the other is
about enum and non-enum in a conditional statement.
==========

to

==========
Fix GCC warnings to be ready for GCC standalone build

ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.

One warning is about maybe using uninitialized variable, the other is
about enum and non-enum in a conditional statement.

Committed:
https://pdfium.googlesource.com/pdfium/+/01e624fb699af3a8ee2f81620d59d366dac1...
==========

[commit-bot: I haz the power, 2016-05-13 23:59:54]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/01e624fb699af3a8ee2f81620d59d366dac1...