Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1981553002: Update export_tarball.py (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Update export_tarball.py - Exclude .git directories only. Stop mentioning SVN. - Exclude the out directory. - Remove obsolete non-essential directories from the list. - Move some non-essential directories to the test data list. - Add a list of essential files to override the non-essential dir list. BUG=611199 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -33 lines) Patch
M scripts/slave/recipe_modules/chromium/resources/export_tarball.py View 6 chunks +27 lines, -33 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Lei Zhang
The build.git edition of https://codereview.chromium.org/1975643002/
4 years, 7 months ago (2016-05-13 20:33:34 UTC) #3
Lei Zhang
The build.git edition of https://codereview.chromium.org/1975643002/
4 years, 7 months ago (2016-05-13 20:33:34 UTC) #4
Paweł Hajdan Jr.
LGTM
4 years, 7 months ago (2016-05-16 09:58:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981553002/1
4 years, 7 months ago (2016-05-16 18:37:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300596
4 years, 7 months ago (2016-05-16 18:41:03 UTC) #9
qyearsley
4 years, 7 months ago (2016-05-17 16:54:40 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1984053003/ by qyearsley@chromium.org.

The reason for reverting is: Failure in the export_tarball step

Example build:
https://build.chromium.org/p/chromium.infra.cron/builders/publish_tarball/bui...

Traceback (most recent call last):
  File
"/b/build/scripts/slave/recipe_modules/chromium/resources/export_tarball.py",
line 191, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/build/scripts/slave/recipe_modules/chromium/resources/export_tarball.py",
line 167, in main
    archive.add(options.src_dir, arcname=output_basename)
  File
"/b/build/scripts/slave/recipe_modules/chromium/resources/export_tarball.py",
line 100, in add
    rel_name = os.path.relpath(name, GetSourceDirectory())
NameError: global name 'GetSourceDirectory' is not defined.

Powered by Google App Engine
This is Rietveld 408576698