Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 198153004: Use a mock WebAudioDevice only when testing (Closed)

Created:
6 years, 9 months ago by elecro
Modified:
6 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use a mock WebAudioDevice only when testing Currently when running the content shell a mock WebAudioDevice is used, but the mock device should only be returned when we are testing. BUG=none R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/shell/renderer/shell_content_renderer_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
elecro
Original CL which introduced the mock WebAudioDevice: https://chromiumcodereview.appspot.com/19023003
6 years, 9 months ago (2014-03-13 17:43:40 UTC) #1
elecro
Added reviewers from the original patch.
6 years, 9 months ago (2014-03-17 16:36:26 UTC) #2
Avi (use Gerrit)
The code LG, but I don't know enough about this area to know if this ...
6 years, 9 months ago (2014-03-17 17:56:50 UTC) #3
jam
this change looks fine to me, but before you can land it you need to ...
6 years, 9 months ago (2014-03-17 18:49:06 UTC) #4
elecro
On 2014/03/17 18:49:06, jam wrote: > this change looks fine to me, but before you ...
6 years, 9 months ago (2014-03-18 09:03:57 UTC) #5
elecro
On 2014/03/18 09:03:57, pgal.u-szeged wrote: > On 2014/03/17 18:49:06, jam wrote: > > this change ...
6 years, 9 months ago (2014-03-27 12:16:55 UTC) #6
elecro
On 2014/03/17 18:49:06, jam wrote: > this change looks fine to me, but before you ...
6 years, 8 months ago (2014-04-03 16:19:25 UTC) #7
piman
On 2014/04/03 16:19:25, pgal.u-szeged wrote: > On 2014/03/17 18:49:06, jam wrote: > > this change ...
6 years, 8 months ago (2014-04-03 20:01:01 UTC) #8
elecro
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
6 years, 8 months ago (2014-04-04 12:16:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/198153004/1
6 years, 8 months ago (2014-04-04 12:16:03 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 13:08:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-04 13:08:28 UTC) #12
elecro
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
6 years, 8 months ago (2014-04-04 15:01:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/198153004/1
6 years, 8 months ago (2014-04-04 15:01:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/198153004/1
6 years, 8 months ago (2014-04-04 15:29:45 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 18:53:19 UTC) #16
Message was sent while issue was closed.
Change committed as 261809

Powered by Google App Engine
This is Rietveld 408576698