|
|
Created:
6 years, 9 months ago by elecro Modified:
6 years, 8 months ago CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionUse a mock WebAudioDevice only when testing
Currently when running the content shell a mock WebAudioDevice is used,
but the mock device should only be returned when we are testing.
BUG=none
R=pfeldman@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261809
Patch Set 1 #
Messages
Total messages: 16 (0 generated)
Original CL which introduced the mock WebAudioDevice: https://chromiumcodereview.appspot.com/19023003
Added reviewers from the original patch.
The code LG, but I don't know enough about this area to know if this is what we want.
this change looks fine to me, but before you can land it you need to go through http://dev.chromium.org/developers/contributing-code/#TOC-Get-your-code-ready
On 2014/03/17 18:49:06, jam wrote: > this change looks fine to me, but before you can land it you need to go through > http://dev.chromium.org/developers/contributing-code/#TOC-Get-your-code-ready Okay, could you help me out here a bit: What am I missing? As far as I know I'm on the Corporate CLA, I've created a review for adding myself to the AUTHORS file (https://chromiumcodereview.appspot.com/195813006/) (maybe this shouldn't be a separate CL?).
On 2014/03/18 09:03:57, pgal.u-szeged wrote: > On 2014/03/17 18:49:06, jam wrote: > > this change looks fine to me, but before you can land it you need to go > through > > http://dev.chromium.org/developers/contributing-code/#TOC-Get-your-code-ready > > Okay, could you help me out here a bit: What am I missing? As far as I know I'm > on the Corporate CLA, I've created a review for adding myself to the AUTHORS > file (https://chromiumcodereview.appspot.com/195813006/) (maybe this shouldn't > be a separate CL?). ping?
On 2014/03/17 18:49:06, jam wrote: > this change looks fine to me, but before you can land it you need to go through > http://dev.chromium.org/developers/contributing-code/#TOC-Get-your-code-ready I'm in the Authors file, I've got CCLA, the style is the same as the other methods, what am I missing here?
On 2014/04/03 16:19:25, pgal.u-szeged wrote: > On 2014/03/17 18:49:06, jam wrote: > > this change looks fine to me, but before you can land it you need to go > through > > http://dev.chromium.org/developers/contributing-code/#TOC-Get-your-code-ready > > I'm in the Authors file, I've got CCLA, the style is the same as the other > methods, what am I missing here? LGTM (I verified the CLA signers doc).
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/1981...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/1981...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/1981...
Message was sent while issue was closed.
Change committed as 261809 |