Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1981523003: Add missing security OWNERS for mojoms in //components and //services. (Closed)

Created:
4 years, 7 months ago by dcheng
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, Donn Denman, Elliot Glaysher, Fady Samuel, jam, mdjones, rjkroege, wychen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing security OWNERS for mojoms in //components and //services. BUG=611905 Committed: https://crrev.com/89cbc40989333929ad9768a3aa86cbab8adf518b Cr-Commit-Position: refs/heads/master@{#393844}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-11 lines, --11 lines) Patch
A + components/contextual_search/common/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/dom_distiller/content/common/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/filesystem/public/interfaces/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/font_service/public/interfaces/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/leveldb/public/interfaces/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/mus/public/interfaces/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/safe_json/public/interfaces/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/catalog/public/interfaces/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/shell/public/interfaces/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/tracing/public/interfaces/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/user/public/interfaces/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
dcheng
4 years, 7 months ago (2016-05-13 23:30:31 UTC) #2
dcheng
Updated this to add things in //services as well.
4 years, 7 months ago (2016-05-13 23:41:39 UTC) #4
dcheng
+rickyz, mind reviewing this? I'll TBR jam, we should land this ASAP
4 years, 7 months ago (2016-05-14 06:58:45 UTC) #6
Anand Mistry (off Chromium)
Sorry if this is a naive questions, but why not add to the top-level OWNERS ...
4 years, 7 months ago (2016-05-15 23:36:10 UTC) #7
dcheng
On 2016/05/15 at 23:36:10, amistry wrote: > Sorry if this is a naive questions, but ...
4 years, 7 months ago (2016-05-16 00:21:09 UTC) #8
jam
lgtm
4 years, 7 months ago (2016-05-16 15:49:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981523003/20001
4 years, 7 months ago (2016-05-16 16:08:09 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-16 16:40:59 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 16:42:29 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89cbc40989333929ad9768a3aa86cbab8adf518b
Cr-Commit-Position: refs/heads/master@{#393844}

Powered by Google App Engine
This is Rietveld 408576698