Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1981483002: Fix regex to parse Variations UI override strings (Closed)

Created:
4 years, 7 months ago by tbansal1
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix regex to parse Variations UI override strings Regex macro used to parse the UI override strings does not work for the generation enabled. This CL adds support to handle the pragma directive present in #define macro format. BUG=611273 Review-Url: https://codereview.chromium.org/1969243002 Cr-Commit-Position: refs/heads/master@{#393295} (cherry picked from commit e60a3b28edd120d48777c7bd16b5b8e9793e4d57) Committed: https://chromium.googlesource.com/chromium/src/+/ab7b10c36b9f79b8ae73f5ec9d2376640f6a31b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M components/variations/service/generate_ui_string_overrider.py View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
4 years, 7 months ago (2016-05-13 18:24:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab7b10c36b9f79b8ae73f5ec9d2376640f6a31b3.

Powered by Google App Engine
This is Rietveld 408576698