Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: runtime/bin/main.cc

Issue 1981453002: Improve the help message for --observe to be more explicit. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index ab45b95aac2ca35fcc0f081b7f3860c5e5b1647f..c296cdedd427b222f779d4a78b973b583087721e 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -384,7 +384,7 @@ static bool ProcessEnableVmServiceOption(const char* option_value,
DEFAULT_VM_SERVICE_SERVER_PORT,
DEFAULT_VM_SERVICE_SERVER_IP)) {
Log::PrintErr("unrecognized --enable-vm-service option syntax. "
- "Use --enable-vm-service[:<port number>[/<IPv4 address>]]\n");
+ "Use --enable-vm-service[=<port number>[/<IPv4 address>]]\n");
return false;
}
@@ -402,10 +402,11 @@ static bool ProcessObserveOption(const char* option_value,
DEFAULT_VM_SERVICE_SERVER_PORT,
DEFAULT_VM_SERVICE_SERVER_IP)) {
Log::PrintErr("unrecognized --observe option syntax. "
- "Use --observe[:<port number>[/<IPv4 address>]]\n");
+ "Use --observe[=<port number>[/<IPv4 address>]]\n");
return false;
}
+ // These options should also be documented in the help message.
vm_options->AddArgument("--pause-isolates-on-exit");
vm_options->AddArgument("--pause-isolates-on-unhandled-exceptions");
vm_options->AddArgument("--warn-on-pause-with-no-debugger");
@@ -855,11 +856,14 @@ static void PrintUsage() {
"--packages=<path>\n"
" Where to find a package spec file.\n"
"--observe[=<port>[/<bind-address>]]\n"
-" The observe flag is used to run a program with a default set of options\n"
-" for debugging under Observatory. With the default options, Observatory\n"
-" will be available at http://127.0.0.1:8181/ (default port is 8181,\n"
-" default bind address is 127.0.0.1). Isolates will pause at exit and\n"
-" when they throw unhandled exceptions.\n"
+" The observe flag is a convenience flag used to run a program with a\n"
+" set of options which are often useful for debugging under Observatory.\n"
+" These default options are:\n"
+" --enable-vm-service[=<port>[/<bind-address>]]\n"
+" --pause-isolates-on-exit\n"
+" --pause-isolates-on-unhandled-exceptions\n"
+" --warn-on-pause-with-no-debugger\n"
+" Please see these options (--help --verbose) for further documentation.\n"
"--version\n"
" Print the VM version.\n");
} else {
@@ -875,11 +879,14 @@ static void PrintUsage() {
"--packages=<path>\n"
" Where to find a package spec file.\n"
"--observe[=<port>[/<bind-address>]]\n"
-" The observe flag is used to run a program with a default set of options\n"
-" for debugging under Observatory. With the default options, Observatory\n"
-" will be available at http://127.0.0.1:8181/ (default port is 8181,\n"
-" default bind address is 127.0.0.1). Isolates will pause at exit and\n"
-" when they throw unhandled exceptions.\n"
+" The observe flag is a convenience flag used to run a program with a\n"
+" set of options which are often useful for debugging under Observatory.\n"
+" These default options are:\n"
+" --enable-vm-service[=<port>[/<bind-address>]]\n"
+" --pause-isolates-on-exit\n"
+" --pause-isolates-on-unhandled-exceptions\n"
+" --warn-on-pause-with-no-debugger\n"
+" Please see these options for further documentation.\n"
"--version\n"
" Print the VM version.\n"
"\n"
@@ -889,7 +896,7 @@ static void PrintUsage() {
"--trace-loading\n"
" enables tracing of library and script loading\n"
"\n"
-"--enable-vm-service[:<port>[/<bind-address>]]\n"
+"--enable-vm-service[=<port>[/<bind-address>]]\n"
" enables the VM service and listens on specified port for connections\n"
" (default port number is 8181, default bind address is 127.0.0.1).\n"
"\n"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698