Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1981443002: GN: Unconditionally write build.ninja. (Closed)

Created:
4 years, 7 months ago by brettw
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Unconditionally write build.ninja. I previously changed this to WriteFileIfChanged which tends to be faster, especially on Windows. But Ninja's build dependency tracking expects the timestamp of this file to be updated whenever any build input has been modified. BUG=611633 Committed: https://crrev.com/94b0b56868bb971253dc8f30b0b6aa3a846e70a4 Cr-Commit-Position: refs/heads/master@{#393591}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M tools/gn/ninja_build_writer.cc View 1 1 chunk +16 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981443002/1
4 years, 7 months ago (2016-05-13 17:27:52 UTC) #2
brettw
fix
4 years, 7 months ago (2016-05-13 17:29:45 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981443002/20001
4 years, 7 months ago (2016-05-13 17:29:54 UTC) #5
brettw
4 years, 7 months ago (2016-05-13 17:30:05 UTC) #7
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-13 17:37:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981443002/20001
4 years, 7 months ago (2016-05-13 17:38:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 18:41:14 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 18:42:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94b0b56868bb971253dc8f30b0b6aa3a846e70a4
Cr-Commit-Position: refs/heads/master@{#393591}

Powered by Google App Engine
This is Rietveld 408576698