Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 1981423002: [MD settings] change button padding and placement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_shared_css.html
diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html
index 001f436da70d99c2c4a73ae16f70296689bf276e..9559a07376634a5823bf85d24d027d56b4a63e09 100644
--- a/chrome/browser/resources/settings/settings_shared_css.html
+++ b/chrome/browser/resources/settings/settings_shared_css.html
@@ -59,7 +59,11 @@
}
paper-button {
+ @apply(--layout-center);
+ display: flex;
margin: 0;
+ min-height: 32px;
+ padding: 0 12px;
}
paper-button[toggles][active] {
@@ -90,7 +94,6 @@
font-weight: 500;
text-align: start;
};
- margin: 0 -0.57em; /* Offsets default paper-button padding. */
}
paper-button.secondary-button {
@@ -136,11 +139,6 @@
white-space: nowrap;
}
- .button-row {
- display: flex;
- margin-top: 25px;
- }
-
.button-strip {
text-align: end;
}
@@ -224,6 +222,15 @@
padding: 0 20px;
}
+ /* The button-strip inside of a settings-box is moved over a small amount
+ * to line up the text of the button label with the 20px settings-box
+ * margin. See also: .secondary-action for buttons at the end of the row.
+ */
+ .settings-box.button-strip {
+ /* Plus 12px for the button equals 20px total. */
+ -webkit-padding-start: 8px;
+ }
+
.settings-box.first,
.settings-box.continuation {
border-top: none;
@@ -261,10 +268,17 @@
* +-------------------------------------------------------+
* | Another setting-box without a secondary-action |
* +-------------------------------------------------------+
+ *
+ * See also: .button-strip for buttons at the start of the row.
*/
.settings-box .secondary-action {
+ @apply(--layout-center);
-webkit-border-start: var(--settings-separator-line);
- -webkit-padding-start: 20px;
+ -webkit-padding-start: 8px;
+ display: flex;
+ left: 12px; /* Equal to the paper-button padding. */
Dan Beam 2016/05/18 00:32:47 wont work in RTL
dschuyler 2016/05/18 20:29:04 Done.
+ min-height: 32px;
+ position: relative;
}
.settings-box paper-item iron-icon {

Powered by Google App Engine
This is Rietveld 408576698