Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1981413002: Remove Is{RVH}OnSwappedOutList, now that swappedout:// is gone. (Closed)

Created:
4 years, 7 months ago by Charlie Reis
Modified:
4 years, 7 months ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, nasko, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Is{RVH}OnSwappedOutList, now that swappedout:// is gone. BUG=357747 TEST=No behavior change. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/9db10ee144d589ffc38b1283426ff0e7025bcea6 Cr-Commit-Position: refs/heads/master@{#394907}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -55 lines) Patch
M content/browser/frame_host/render_frame_host_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 2 chunks +9 lines, -15 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.h View 3 chunks +1 line, -10 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
Charlie Reis
Noticed this was still around as dead code, so I went ahead and removed it.
4 years, 7 months ago (2016-05-17 18:34:43 UTC) #3
alexmos
Thanks, LGTM with nit. https://codereview.chromium.org/1981413002/diff/1/content/browser/frame_host/render_frame_host_manager_unittest.cc File content/browser/frame_host/render_frame_host_manager_unittest.cc (right): https://codereview.chromium.org/1981413002/diff/1/content/browser/frame_host/render_frame_host_manager_unittest.cc#newcode1341 content/browser/frame_host/render_frame_host_manager_unittest.cc:1341: // Ensure a swapped out ...
4 years, 7 months ago (2016-05-18 00:01:35 UTC) #4
Charlie Reis
https://codereview.chromium.org/1981413002/diff/1/content/browser/frame_host/render_frame_host_manager_unittest.cc File content/browser/frame_host/render_frame_host_manager_unittest.cc (right): https://codereview.chromium.org/1981413002/diff/1/content/browser/frame_host/render_frame_host_manager_unittest.cc#newcode1341 content/browser/frame_host/render_frame_host_manager_unittest.cc:1341: // Ensure a swapped out RFH and RFH is ...
4 years, 7 months ago (2016-05-19 17:11:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981413002/20001
4 years, 7 months ago (2016-05-19 17:11:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/114282)
4 years, 7 months ago (2016-05-19 18:08:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981413002/20001
4 years, 7 months ago (2016-05-19 18:14:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/114343)
4 years, 7 months ago (2016-05-19 18:58:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981413002/20001
4 years, 7 months ago (2016-05-19 21:03:22 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 23:39:27 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 23:42:29 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9db10ee144d589ffc38b1283426ff0e7025bcea6
Cr-Commit-Position: refs/heads/master@{#394907}

Powered by Google App Engine
This is Rietveld 408576698