Do not show "Error calling GetScreenBrightnessPercent" in VMTests.

Do not show "Error calling GetScreenBrightnessPercent" in VMTests.

This error message shows up on every successful/failed VMtest which
causes log spams and makes it difficult to identify actual errors.
In order to prevent that, we only show this error message when we're
not running in a VMTest.

BUG=585514

[Daniel Erat, 2016-05-17 20:13:22]

derat@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2016-05-17 20:13:22]

lgtm

[achuithb, 2016-05-17 20:18:50]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2016-05-17 20:18:51]

https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
chromeos/dbus/power_manager_client.cc:51: const char kVMSystemVendor[] = "QEMU";
We have this same definition here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...

I think it may be time to add a function like
IsRunningInVM() to StatisticsProvider instead of doing this same comparison
everywhere.

https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
chromeos/dbus/power_manager_client.cc:476: system_vendor != kVMSystemVendor) {
Are we confident that this check works in the VM? Have you tested it on the
trybots?

[xdai1, 2016-05-17 20:35:56]

https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
chromeos/dbus/power_manager_client.cc:476: system_vendor != kVMSystemVendor) {
On 2016/05/17 20:18:51, achuithb wrote:
> Are we confident that this check works in the VM? Have you tested it on the
> trybots?

I tested this in the VMTest locally and it worked fine. How can I test it on the
trybots?

[achuithb, 2016-05-17 21:10:47]

https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
chromeos/dbus/power_manager_client.cc:476: system_vendor != kVMSystemVendor) {
On 2016/05/17 20:35:55, xdai1 wrote:
> On 2016/05/17 20:18:51, achuithb wrote:
> > Are we confident that this check works in the VM? Have you tested it on the
> > trybots?
> 
> I tested this in the VMTest locally and it worked fine. How can I test it on
the
> trybots? 

The previous hwid change (http://crbug.com/585515) - did it suppress the logging
as you expected in VM tests?

I see that 585515 was bulk verified, but could you please verify by looking at
VM test logs and ensuring that the message was suppressed as you'd expect?

[xdai1, 2016-05-17 21:35:17]

https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
chromeos/dbus/power_manager_client.cc:476: system_vendor != kVMSystemVendor) {
On 2016/05/17 21:10:47, achuithb wrote:
> On 2016/05/17 20:35:55, xdai1 wrote:
> > On 2016/05/17 20:18:51, achuithb wrote:
> > > Are we confident that this check works in the VM? Have you tested it on
the
> > > trybots?
> > 
> > I tested this in the VMTest locally and it worked fine. How can I test it on
> the
> > trybots? 
> 
> The previous hwid change (http://crbug.com/585515) - did it suppress the
logging
> as you expected in VM tests?
> 
> I see that 585515 was bulk verified, but could you please verify by looking at
> VM test logs and ensuring that the message was suppressed as you'd expect? 

I just checked and unfortunately the HWID error is still there, which means the
system vendor check does not work in real VMTests(trybots) :(

[achuithb, 2016-05-17 21:38:12]

On 2016/05/17 21:35:17, xdai1 wrote:
>
https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
> File chromeos/dbus/power_manager_client.cc (right):
> 
>
https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
> chromeos/dbus/power_manager_client.cc:476: system_vendor != kVMSystemVendor) {
> On 2016/05/17 21:10:47, achuithb wrote:
> > On 2016/05/17 20:35:55, xdai1 wrote:
> > > On 2016/05/17 20:18:51, achuithb wrote:
> > > > Are we confident that this check works in the VM? Have you tested it on
> the
> > > > trybots?
> > > 
> > > I tested this in the VMTest locally and it worked fine. How can I test it
on
> > the
> > > trybots? 
> > 
> > The previous hwid change (http://crbug.com/585515) - did it suppress the
> logging
> > as you expected in VM tests?
> > 
> > I see that 585515 was bulk verified, but could you please verify by looking
at
> > VM test logs and ensuring that the message was suppressed as you'd expect? 
> 
> I just checked and unfortunately the HWID error is still there, which means
the
> system vendor check does not work in real VMTests(trybots) :(

Yup, this is what I expected.

Can we add some logging to see what the SysVendor is on the GCE VMs?

[xdai1, 2016-05-17 21:40:45]

On 2016/05/17 21:38:12, achuithb wrote:
> On 2016/05/17 21:35:17, xdai1 wrote:
> >
>
https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
> > File chromeos/dbus/power_manager_client.cc (right):
> > 
> >
>
https://codereview.chromium.org/1981383002/diff/1/chromeos/dbus/power_manager...
> > chromeos/dbus/power_manager_client.cc:476: system_vendor != kVMSystemVendor)
{
> > On 2016/05/17 21:10:47, achuithb wrote:
> > > On 2016/05/17 20:35:55, xdai1 wrote:
> > > > On 2016/05/17 20:18:51, achuithb wrote:
> > > > > Are we confident that this check works in the VM? Have you tested it
on
> > the
> > > > > trybots?
> > > > 
> > > > I tested this in the VMTest locally and it worked fine. How can I test
it
> on
> > > the
> > > > trybots? 
> > > 
> > > The previous hwid change (http://crbug.com/585515) - did it suppress the
> > logging
> > > as you expected in VM tests?
> > > 
> > > I see that 585515 was bulk verified, but could you please verify by
looking
> at
> > > VM test logs and ensuring that the message was suppressed as you'd expect?

> > 
> > I just checked and unfortunately the HWID error is still there, which means
> the
> > system vendor check does not work in real VMTests(trybots) :(
> 
> Yup, this is what I expected.
> 
> Can we add some logging to see what the SysVendor is on the GCE VMs?

Sure. I will add some log in another CL and keep this issue open until we figure
it out.

[xdai1, 2016-08-23 16:19:56]

This has been fixed in https://codereview.chromium.org/2218003005. 
Thus close this CL.