Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1981363002: In summary AST linker, fix top level isStatic getters. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

In summary AST linker, fix top level isStatic getters. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f5ffdf16046b3f5223527c879c72953854590426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-17 17:09:53 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-17 17:10:49 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-17 17:19:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5ffdf16046b3f5223527c879c72953854590426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698