Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/analysis_server/lib/src/services/correction/fix_internal.dart

Issue 1981353002: Issue 26460. Add Quick Fix for missing 'Function.call()' implementation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/correction/fix_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
index f855a29025f46218b402b568e90d5657a991cf40..117884d2ca5bd8b9605c3a21b0b1c99559675891 100644
--- a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
+++ b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
@@ -245,6 +245,9 @@ class FixProcessor {
_addFix_createConstructor_insteadOfSyntheticDefault();
_addFix_addMissingParameter();
}
+ if (errorCode == StaticWarningCode.FUNCTION_WITHOUT_CALL) {
+ _addFix_addMissingMethodCall();
+ }
if (errorCode == StaticWarningCode.NEW_WITH_UNDEFINED_CONSTRUCTOR) {
_addFix_createConstructor_named();
}
@@ -415,6 +418,32 @@ class FixProcessor {
}
}
+ void _addFix_addMissingMethodCall() {
+ ClassDeclaration targetClass = node.parent as ClassDeclaration;
+ // prepare SourceBuilder
+ int insertOffset = targetClass.end - 1;
+ SourceBuilder sb = new SourceBuilder(file, insertOffset);
+ // prepare environment
+ String prefix = utils.getIndent(1);
+ String prefix2 = utils.getIndent(2);
+ // start method
+ sb.append(prefix);
+ sb.append('call() {');
+ // TO-DO
+ sb.append(eol);
+ sb.append(prefix2);
+ sb.append('// TODO: implement call');
+ sb.append(eol);
+ // close method
+ sb.append(prefix);
+ sb.append('}');
+ sb.append(eol);
+ // add proposal
+ exitPosition = new Position(file, insertOffset);
+ _insertBuilder(sb, unitElement);
+ _addFix(DartFixKind.CREATE_MISSING_METHOD_CALL, []);
+ }
+
void _addFix_addMissingParameter() {
if (node is ArgumentList && node.parent is MethodInvocation) {
ArgumentList argumentList = node;
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/fix.dart ('k') | pkg/analysis_server/test/services/correction/fix_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698