Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 1981333003: [wasm] Allow validator to inspect entire module. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
titzer, bradnelson, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Allow validator to inspect entire module. This changes the parser to keep around bodies for asm.js functions when then asm.js validator is turned on. Eventually the validator will work on one function at a time, but for now we validate the entire module at once. R=rossberg@chromium.org Committed: https://crrev.com/328d6037dd09f9d85aefbadb7177b684a28606ea Cr-Commit-Position: refs/heads/master@{#36291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/parsing/parser.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
Brad & Ben: FYI, to get the validator going. Andreas: Needs parser review.
4 years, 7 months ago (2016-05-17 17:16:22 UTC) #2
bradnelson
lgtm, but need owners from others.
4 years, 7 months ago (2016-05-17 17:19:12 UTC) #3
rossberg
lgtm
4 years, 7 months ago (2016-05-17 17:20:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981333003/1
4 years, 7 months ago (2016-05-17 17:23:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 17:42:37 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 17:45:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/328d6037dd09f9d85aefbadb7177b684a28606ea
Cr-Commit-Position: refs/heads/master@{#36291}

Powered by Google App Engine
This is Rietveld 408576698