Fix Brotli warnings on Windows

Fix Brotli warnings on Windows

Brotli files have some warnings that kill the Windows compiler. This
change modifies the Brotli source files to pass the Windows compile.

BUG=612349
Committed: https://crrev.com/b8adfa4cfb3e1e06b473428a79090e92edf4ab8d
Cr-Commit-Position: refs/heads/master@{#394397}

[smaier, 2016-05-17 15:51:28]

smaier@chromium.org changed reviewers:
+ brucedawson@chromium.org, eustas@chromium.org

[smaier, 2016-05-17 15:51:28]

Take a look at this change, let me know if this looks like it'll work for
Windows. I'm working on getting it verified right now.

[eustas, 2016-05-17 16:05:44]

lgtm

[brucedawson, 2016-05-17 17:46:49]

I've confirmed that "bro" now builds cleanly on Windows where it used to fail.

[brucedawson, 2016-05-17 17:46:59]

lgtm

[smaier, 2016-05-17 17:48:23]

smaier@chromium.org changed reviewers:
+ ksakamoto@chromium.org, sky@chromium.org

[smaier, 2016-05-17 17:48:23]

ksakamoto@chromium.org, sky@chromium.org: Please review changes in
third_party/brotli

[sky, 2016-05-17 19:28:34]

On 2016/05/17 17:48:23, smaier wrote:
> mailto:ksakamoto@chromium.org, mailto:sky@chromium.org: Please review changes
in
> third_party/brotli

I'm not a good reviewer for brotli. ksakamoto is in the owners file, so you
shouldn't need me. I'm removing myself as a reviewer from this.

[sky, 2016-05-17 19:28:41]

Description was changed from

==========
Fix Brotli warnings on Windows

Brotli files have some warnings that kill the Windows compiler. This
change modifies the Brotli source files to pass the Windows compile.

BUG=612349
==========

to

==========
Fix Brotli warnings on Windows

Brotli files have some warnings that kill the Windows compiler. This
change modifies the Brotli source files to pass the Windows compile.

BUG=612349
==========

[sky, 2016-05-17 19:28:41]

sky@chromium.org changed reviewers:
- sky@chromium.org

[brucedawson, 2016-05-17 20:23:59]

Also, if you would prefer to suppress the warnings in the .gyp and .gn files, in
order to avoid changing the source, let me know and I can help with that.

[Kunihiko Sakamoto, 2016-05-18 01:29:04]

lgtm

eustas@, would you upstream these changes?

[eustas, 2016-05-18 12:08:20]

On 2016/05/18 01:29:04, Kunihiko Sakamoto wrote:
> lgtm
> 
> eustas@, would you upstream these changes?

Actually, in up-up-stream it is fixed more than month ago. Just waiting for the
good moment to publish it to github.

[smaier, 2016-05-18 12:40:32]

The CQ bit was checked by smaier@chromium.org

[commit-bot: I haz the power, 2016-05-18 12:40:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1981333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1981333002/1

[commit-bot: I haz the power, 2016-05-18 13:16:27]

Description was changed from

==========
Fix Brotli warnings on Windows

Brotli files have some warnings that kill the Windows compiler. This
change modifies the Brotli source files to pass the Windows compile.

BUG=612349
==========

to

==========
Fix Brotli warnings on Windows

Brotli files have some warnings that kill the Windows compiler. This
change modifies the Brotli source files to pass the Windows compile.

BUG=612349
==========

[commit-bot: I haz the power, 2016-05-18 13:16:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-18 13:17:53]

Description was changed from

==========
Fix Brotli warnings on Windows

Brotli files have some warnings that kill the Windows compiler. This
change modifies the Brotli source files to pass the Windows compile.

BUG=612349
==========

to

==========
Fix Brotli warnings on Windows

Brotli files have some warnings that kill the Windows compiler. This
change modifies the Brotli source files to pass the Windows compile.

BUG=612349

Committed: https://crrev.com/b8adfa4cfb3e1e06b473428a79090e92edf4ab8d
Cr-Commit-Position: refs/heads/master@{#394397}
==========

[commit-bot: I haz the power, 2016-05-18 13:17:54]

Patchset 1 (id:??) landed as
https://crrev.com/b8adfa4cfb3e1e06b473428a79090e92edf4ab8d
Cr-Commit-Position: refs/heads/master@{#394397}