src/compiler/ast-graph-builder.cc - Issue 1981323002: [compiler] Remove obsolete JSYield operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1981323002: [compiler] Remove obsolete JSYield operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Reenable VisitYield Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-graph-builder.cc

diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc

index ddd8610b902f1a7db1371e148259aa3fefdfbea2..da8b62607c6181f8c559e5fc816aac84f4500c59 100644

--- a/src/compiler/ast-graph-builder.cc

+++ b/src/compiler/ast-graph-builder.cc

@@ -2251,7 +2251,7 @@ void AstGraphBuilder::VisitAssignment(Assignment* expr) {

void AstGraphBuilder::VisitYield(Yield* expr) {

- // TODO(turbofan): Implement yield here.

+ // Generator functions are supported only by going through Ignition first.

SetStackOverflow();

ast_context()->ProduceValue(jsgraph()->UndefinedConstant());

}

« no previous file with comments | « no previous file | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »